Removed dir option from pfioh & used pfstorage module#62
Conversation
|
Hey @arnavn101 -- I don't understand your logic here. Can you explain what you are doing? I thought we were removing the --storeBase CLI which is not what this is? Best |
|
Hi @rudolphpienaar, This is version that requires directory to be specified : https://github.com/FNNDSC/pfioh/wiki/pfioh-command:-pushPath-(absolute)-using-zip#pfurl-calling-syntax This is keystore version : https://github.com/FNNDSC/pfioh/wiki/pfioh-command:-pushPath-(keystore)-using-zip#pfurl-calling-syntax |
|
This is strictly speaking incorrect.
The directory specification is a valid and needed use case of pfioh in
the general sense -- thus I don't think I can merge this. In other
words, pfioh is a general tool and it is not correct to assume it will
always have some keystore. There are definitely cases where it is used
as a sort of ftp-type setup and actually saves to specific directory
locations.
Let's touch base tomorrow in the meeting or in slack and I can explain
better.
…On Tue, 2019-08-27 at 13:49 -0700, Arnav N wrote:
Hi @rudolphpienaar,
There are currently two ways of running the pushPath & pullPath pfioh
commands. However, only the keystore version of command is required.
So, I deleted lines of code that requires a directory to be specified
to use push & pull functions of pfioh.
|
arnavn101
changed the title
|
LGTM |
| if k == 'is_zip': b_zip = v | ||
| if k == 'd_ret': d_ret = v | ||
|
|
||
| if str_destPath == '': |
There was a problem hiding this comment.
Unless we are worried about str_desPath not being a string, you should be able to use if str_destPath since empty string is false.
|
The other thing to do with this PR is find any doc references to using the API. |
|
@danmcp @rudolphpienaar do not merge this. I am still testing it. |
5 participants
Resolved this issue: redhat-university-partnerships/radiology#50