feat: external summary statistics support#233
Open
juhis wants to merge 1 commit into
Open
Conversation
Support consuming non-FinnGen GWAS summary statistics, which differ from FinnGen sumstats in three ways this addresses: - --pval-is-mlog10p: accept -log10(p) inputs, with thresholds, comparisons and sorts handled in the correct direction. The dynamic LD threshold is computed in log space via ndtri_exp so ultra-significant p-values do not underflow (chi2_1.isf(p) == ndtri(p/2)**2). - tolerant extra columns: warn and skip requested --extra-cols absent from the file instead of raising. - --finngen-variants-only: drop loci/variants not present in FinnGen. Consolidate the significance filter to a single inclusive helper (_passes_threshold_eq) per review of #230. Add unit tests and WDL wiring for the new flags. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support consuming non-FinnGen GWAS summary statistics, which differ from FinnGen sumstats in three ways this addresses:
Consolidate the significance filter to a single inclusive helper (_passes_threshold_eq) per review of #230. Add unit tests and WDL wiring for the new flags.