Skip to content

docs(storage): refresh provider examples#75

Open
snissn wants to merge 3 commits into
upstream/docs-ia-refreshfrom
ger-640-provide-storage-audit
Open

docs(storage): refresh provider examples#75
snissn wants to merge 3 commits into
upstream/docs-ia-refreshfrom
ger-640-provide-storage-audit

Conversation

@snissn

@snissn snissn commented Jun 3, 2026

Copy link
Copy Markdown
Member

Summary

  • Refresh Provide Storage operator examples for current Lotus and Curio releases.
  • Replace stale Lotus, Go, and PDP branch references with release-tag-based commands and current expected outputs.
  • Remove copyable JWT/private-key example values and use shell variables or placeholders for sensitive data.
  • Fix a truncated Lotus config sed command and narrow Lotus build/install examples to daemon targets where appropriate.
  • Address Copilot review feedback by replacing GNU-specific sort -V snippets and documenting why PDP uses Go 1.26.0.
  • Merge the current upstream/docs-ia-refresh base so this PR is reviewable after PR docs(storage): refresh store and retrieval examples #76 landed.

Context

Validation

  • git diff --check
  • stale-pattern scan for old Lotus/Go/PDP branch/token examples
  • npm run build
  • Checked live upstream release/tooling state during implementation:
    • Lotus latest release v1.36.0; go.mod declares go 1.25.7; Makefile exposes lotus, calibnet-*, calibnet, and install-daemon targets.
    • Curio latest release v1.28.1; go.mod declares go 1.26; Makefile exposes build, calibnet, and install targets.
  • Benchmarks: not applicable; docs-only changes.

Review Readiness

  • Latest head: 4f5149706e47d983b01058bb9b911b20d42206a1.
  • GitHub merge state: CLEAN.
  • Netlify deploy preview: passed at https://deploy-preview-75--timely-kataifi-9f3a09.netlify.app.
  • Netlify helper checks: Header rules, Pages changed, and Redirect rules completed as neutral.
  • Review threads: all 5 Copilot review threads are resolved through GitHub reviewThreads.
  • Copilot: initial review generated 5 findings; all were fixed and resolved. Follow-up @copilot review triggered Copilot cloud-agent run 26858427344, which completed successfully on the previous reviewed head and made no branch changes.
  • CodeRabbit: @coderabbitai review requested; no CodeRabbit response was posted after polling. Formal reviewer request was rejected by GitHub because the bot user is not a collaborator in this fork.
  • Codex: @codex review requested; chatgpt-codex-connector replied that Codex is not connected for this repo/account, so Codex review is unavailable.

Merge

Do not merge yet; this PR is a mergeable handoff for reviewer inspection and human merge approval.

Copilot AI review requested due to automatic review settings June 3, 2026 00:57
@netlify

netlify Bot commented Jun 3, 2026

Copy link
Copy Markdown

Deploy Preview for timely-kataifi-9f3a09 ready!

Name Link
🔨 Latest commit 4f51497
🔍 Latest deploy log https://app.netlify.com/projects/timely-kataifi-9f3a09/deploys/6a2341e8f1b3730008257e64
😎 Deploy Preview https://deploy-preview-75--timely-kataifi-9f3a09.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refreshes Provide Storage operator documentation to match current Lotus/Curio releases, modernizes build/install commands to use release tags and current Makefile targets, and removes copyable sensitive token/key examples in favor of variables/placeholders.

Changes:

  • Updated Go/Lotus/Curio version pinning and build instructions (including calibration targets and daemon-only installs where appropriate).
  • Replaced hard-coded JWT/token/key examples with shell variables/placeholders and added safer handling guidance.
  • Fixed/troubleshot instructions (e.g., repaired the truncated sed command; tightened expected outputs).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
storage-providers/pdp/install-and-run-pdp.md Updates PDP stack prerequisites, Lotus/Curio checkout/build steps, safety guidance around secrets, and fixes a broken config-edit command.
storage-providers/nodes/lite-nodes/spin-up-a-lite-node.md Refreshes lite-node setup for current Lotus/Go versions and removes copyable privileged-token examples in favor of env vars.
storage-providers/nodes/full-nodes/basic-setup.md Replaces stale “download/extract binary” flow with a release-tag source-build flow using current Lotus targets and provider guidance links.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread storage-providers/nodes/full-nodes/basic-setup.md Outdated
Comment thread storage-providers/nodes/lite-nodes/spin-up-a-lite-node.md Outdated
Comment thread storage-providers/nodes/lite-nodes/spin-up-a-lite-node.md Outdated
Comment thread storage-providers/nodes/lite-nodes/spin-up-a-lite-node.md Outdated
Comment thread storage-providers/pdp/install-and-run-pdp.md
@snissn

snissn commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

Copilot review disposition for latest head 885402c0f64b6ba132253aacad3f448ccdbf8b45:\n\n- Replaced GNU-specific sort -V tag sorting with Git's built-in version-aware tag sort in the full-node and lite-node examples.\n- Added rationale for Go 1.26.0 in the PDP guide: current Curio requires Go 1.26, while current Lotus requires Go 1.25.7, so the guide uses the higher stack requirement.\n- Revalidated with git diff --check, targeted stale-pattern scans, and npm run build.\n\nResolving the addressed Copilot threads now.

@snissn

snissn commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

@copilot review

@snissn

snissn commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@snissn

snissn commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants