refactor komponentu do tworzenia projektów#64
Merged
Conversation
| { | ||
| "permissions": { | ||
| "allow": [ | ||
| "Bash(Get-ChildItem -Path \"c:\\\\Users\\\\jandy\\\\OneDrive\\\\Pulpit\\\\6 sem\\\\IO\\\\IO-Project\" -Directory)" |
Collaborator
There was a problem hiding this comment.
Tego pliku nie powinno być na repo
|
|
||
| <div className="space-y-3"> | ||
| {milestonesFields.map((field, index) => { | ||
| const lastMilestone = milestones[index - 1]; |
Collaborator
There was a problem hiding this comment.
Przez ułamek sekundy to może być undefined czy coś, chyba bezpieczneij by było tak:
const lastMilestone = milestones?.[index - 1];
| } | ||
| return next; | ||
| }, [usersById, foundUsers]); | ||
| const selectedUserIds = useWatch({ control, name: roles }) ?? []; |
Collaborator
There was a problem hiding this comment.
Linter chyba dobrze mówi z tym warningiem, możesz to owinąć w useMemo, to załatwi sprawę
rrogalski
reviewed
May 25, 2026
| })), | ||
| }); | ||
| }).refine( | ||
| (data) => !data.startDate || !data.endDate || data.endDate >= data.startDate, |
Collaborator
There was a problem hiding this comment.
patrząc na komunikat błędu to chyba to !data.startDate || !data.endDate nie powinno być sprawdzane tutaj
rrogalski
requested changes
May 25, 2026
rrogalski
force-pushed
the
fix-ProjectForm
branch
from
25bdc3a to
bc841b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.