Migrate dependencies from GitHub packages to npm#41
Conversation
- Replace @f88/promidas (github:F88/promidas#v1.1.0) with promidas ^2.0.0 - Replace @f88/promidas-utils (github:F88/promidas-utils#v1.0.0) with promidas-utils ^2.0.0 Refs: #38
- Reorganized import statements for better readability and consistency. - Updated type imports from '@f88/promidas' to 'promidas' and related packages. - Added missing imports in several files to ensure proper functionality. - Cleaned up unused imports and ensured all components and hooks are correctly referencing types. - Adjusted the order of imports in various files to follow a consistent pattern. - Enhanced the structure of the codebase by ensuring all components are using the latest type definitions.
- Removed duplicate entries for "promidas" and "promidas-utils" from the dependencies section. - Added "eslint-import-resolver-typescript" and "eslint-plugin-import" to enhance linting capabilities.
…e ESLint import management
…tidy up Vite config imports
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the project's dependency management from GitHub packages to npm registry, updating package names from @f88/promidas → promidas and @f88/promidas-utils → promidas-utils (both to v2.0.0). The migration includes comprehensive import statement updates across ~50 files and introduces ESLint import management plugins for maintaining consistent import ordering and organization.
Changes:
- Migrated dependencies from GitHub packages to npm with updated package names and versions
- Added ESLint import management with
eslint-plugin-importandeslint-import-resolver-typescript - Updated all import statements and references across the codebase to use new package names
Reviewed changes
Copilot reviewed 119 out of 120 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated dependencies to npm packages and added ESLint import plugins |
| package-lock.json | Updated lockfile with new dependency resolutions |
| eslint.config.mjs | Added import plugin configuration with ordering rules |
| vite.config.ts | Updated build configuration paths and import ordering |
| src/**/*.ts(x) | Updated import statements to use new package names |
| scripts/generate-snapshot.ts | Updated promidas import statements |
| DESIGN.md | Updated architecture diagram reference |
| CHANGELOG.md | Documented migration changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary of ChangesHello @F88, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's dependency management by transitioning core internal packages from a private GitHub Packages setup to the public npm registry. This change simplifies access and maintenance for these dependencies. Concurrently, the PR refines the development environment by integrating advanced ESLint configurations to enforce consistent import practices and improve TypeScript support. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully migrates dependencies from GitHub packages to the public npm registry, which is a significant improvement for dependency management and build consistency. The addition of eslint-plugin-import and the automatic reordering of imports across numerous files greatly enhance code quality and maintainability. The changes are thorough, covering configuration files, source code, and documentation. I have one suggestion to make the manual chunking logic in vite.config.ts more robust, but overall, this is an excellent and well-executed update.
Overview
Migrate dependencies from GitHub packages to npm registry with updated package names.
Changes
Dependencies
@f88/promidas(github:F88/promidas#v1.1.0) →promidas(^2.0.0)@f88/promidas-utils(github:F88/promidas-utils#v1.0.0) →promidas-utils(^2.0.0)Code Updates
ESLint Improvements
eslint-plugin-importfor import managementeslint-import-resolver-typescriptfor TypeScript path resolutionTesting
Closes #38