Skip to content

Fix scoped tool source ordering#2487

Merged
chubes4 merged 1 commit into
mainfrom
fix/adjacent-handler-tool-source-order
Jun 3, 2026
Merged

Fix scoped tool source ordering#2487
chubes4 merged 1 commit into
mainfrom
fix/adjacent-handler-tool-source-order

Conversation

@chubes4
Copy link
Copy Markdown
Member

@chubes4 chubes4 commented Jun 3, 2026

Summary

  • Scope Data Machine's Agents API source-order hook to the active gather call instead of static WeakMap registry tracking.
  • Keep ordering guarded by the exact Data Machine-owned registry instance so adjacent handler tools remain available without affecting other Agents API registries.
  • Update smoke coverage for scoped hook attachment/removal and the adjacent-handler bootstrap.

Verification

  • php tests/tool-source-registry-smoke.php
  • php tests/adjacent-handler-tool-policy-smoke.php
  • php -l inc/Engine/AI/Tools/ToolSourceRegistry.php && php -l tests/tool-source-registry-smoke.php && php -l tests/adjacent-handler-tool-policy-smoke.php
  • vendor/bin/phpcs inc/Engine/AI/Tools/ToolSourceRegistry.php tests/tool-source-registry-smoke.php tests/adjacent-handler-tool-policy-smoke.php

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode (GPT-5.5)
  • Used for: Diagnosing the handler-tool source ordering regression, drafting the scoped registry fix, updating smoke tests, and running local verification. Chris remains responsible for review and merge.

@homeboy-ci
Copy link
Copy Markdown
Contributor

homeboy-ci Bot commented Jun 3, 2026

Homeboy Results — data-machine

Lint

lint — passed

ℹ️ Full options: homeboy docs commands/lint
Deep dive: homeboy lint data-machine --changed-since e98e52f

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-lint-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-lint-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26916091985

Test

test — passed

  • 215 passed

ℹ️ Auto-fix lint issues: homeboy refactor data-machine --from lint --write
ℹ️ Collect coverage: homeboy test data-machine --coverage
ℹ️ Save test baseline: homeboy test data-machine --baseline
ℹ️ Pass args to test runner: homeboy test -- [args]
ℹ️ Full options: homeboy docs commands/test
Deep dive: homeboy test data-machine --changed-since e98e52f

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-test-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-test-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26916091985

Audit

audit — passed

  • audit — 7 finding(s)
  • Total: 7 finding(s)

Deep dive: homeboy audit data-machine --changed-since e98e52f

Artifacts and drill-down
  • CI results artifact: homeboy-ci-results-data-machine-audit-quality-Linux-node24 contains immediate command JSON for this action invocation.
  • Observation artifact: homeboy-observations-data-machine-audit-quality-Linux-node24 contains exported Homeboy run history for deeper queries.
  • Drill-down: download the observation artifact, then run homeboy runs import <dir>, homeboy runs list, and homeboy runs findings <run-id>.
  • Artifacts are attached to the workflow run: https://github.com/Extra-Chill/data-machine/actions/runs/26916091985
Tooling versions
  • Homeboy CLI: homeboy 0.220.0+4294fdd2
  • Extension: wordpress from https://github.com/Extra-Chill/homeboy-extensions
  • Extension revision: 1f9ab9d7
  • Action: unknown@unknown

@chubes4 chubes4 merged commit 2cb25ef into main Jun 3, 2026
5 checks passed
@chubes4 chubes4 deleted the fix/adjacent-handler-tool-source-order branch June 3, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant