fix: Tax - No autofocus in the name editing menu taxes#92153
Open
TaduJR wants to merge 1 commit into
Open
Conversation
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This fixes the missing autofocus on the tax name editing field on iOS by updating the FullStory dependencies to versions that contain the upstream root-cause fix.
Root cause: On iOS,
@fullstory/babel-plugin-react-nativeinjects a syntheticrefinto every element with FullStory attributes (added by@fullstory/babel-plugin-annotate-react). In React 19 these synthetic refs were enumerable, so they leaked through{...rest}spreads in components that don't destructureref. InTextSelectorModal, the leaked phantom ref overwrote the legitimateinputCallbackRefon<InputWrapper>, leavinginputRef.currentnull — so theuseFocusEffectfocus logic silently skipped, and the keyboard never appeared.This only reproduced on iOS Native because FullStory's ref injection is guarded by
Platform.OS === 'ios'and the New Architecture (TurboModules) check.Fix: Reported and fixed upstream in
@fullstory/babel-plugin-react-native. Synthetic refs are now injected as non-enumerable viaObject.defineProperty, so they no longer leak through{...rest}spreads while still being visible to React's reconciler (coerceRefreadsprops.refvia direct property access). This resolves the issue app-wide rather than patching a single page.This PR bumps the FullStory packages to the latest published versions which include the fix:
@fullstory/babel-plugin-react-native^1.5.2^1.6.4@fullstory/babel-plugin-annotate-react^2.3.2^2.4.0@fullstory/browser^2.0.6^2.0.8Fixed Issues
$ #76650
PROPOSAL: #76650 (comment)
Tests
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-05-23.at.12.24.33.AM.mov
Android: mWeb Chrome
Screen.Recording.2026-05-23.at.12.28.46.AM.mov
iOS: Native
Screen.Recording.2026-05-23.at.12.11.24.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-05-23.at.12.18.41.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-23.at.12.16.45.AM.mov