Skip to content

Fix: New expense not visible in grouped-by from search when created offline #92132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aswin-s wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix: New expense not visible in grouped-by from search when created offline #92132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4eaeec2
fix: add optimistic group_ entry for grouped-by-from search when crea…
aswin-s May 30, 2026
855cac9
fix: read live Onyx snapshot to correctly accumulate group count/total
aswin-s May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/libs/actions/IOU/SearchUpdate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {OnyxEntry, OnyxUpdate} from 'react-native-onyx';
import type {OnyxCollection, OnyxEntry, OnyxUpdate} from 'react-native-onyx';
import Onyx from 'react-native-onyx';
import type {ValueOf} from 'type-fest';
import type {SearchQueryJSON} from '@components/Search/types';
Expand All @@ -10,9 +10,18 @@
import type * as OnyxTypes from '@src/types/onyx';
import type {Participant} from '@src/types/onyx/IOU';
import type {OnyxData} from '@src/types/onyx/Request';
import type {SearchResultDataType} from '@src/types/onyx/SearchResults';
import type {SearchMemberGroup, SearchResultDataType} from '@src/types/onyx/SearchResults';
import {getCurrentUserPersonalDetails} from './index';

let allSnapshots: OnyxCollection<OnyxTypes.SearchResults> = {};
Onyx.connect({

Check failure on line 17 in src/libs/actions/IOU/SearchUpdate.ts

View workflow job for this annotation

GitHub Actions / ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function

Check failure on line 17 in src/libs/actions/IOU/SearchUpdate.ts

View workflow job for this annotation

GitHub Actions / ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.SNAPSHOT,
waitForCollectionCallback: true,
callback: (value) => {
allSnapshots = value ?? {};
},
});

type ExpenseReportStatusPredicate = (expenseReport: OnyxEntry<OnyxTypes.Report>, transactionReportID?: string) => boolean;

const expenseReportStatusFilterMapping: Record<string, ExpenseReportStatusPredicate> = {
Expand Down Expand Up @@ -202,6 +211,16 @@
];

if (currentSearchQueryJSON.groupBy === CONST.SEARCH.GROUP_BY.FROM) {
const groupKey = `${CONST.SEARCH.GROUP_PREFIX}${fromAccountID}`;
const currentSnapshot = allSnapshots[`${ONYXKEYS.COLLECTION.SNAPSHOT}${currentSearchQueryJSON.hash}`];

Check failure on line 215 in src/libs/actions/IOU/SearchUpdate.ts

View workflow job for this annotation

GitHub Actions / typecheck 

'allSnapshots' is possibly 'undefined'.
const existingGroup = currentSnapshot?.data?.[groupKey] as SearchMemberGroup | undefined;

Check failure on line 216 in src/libs/actions/IOU/SearchUpdate.ts

View workflow job for this annotation

GitHub Actions / typecheck 

Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'SearchResultDataType'.
optimisticSnapshotData[groupKey] = {

Check failure on line 217 in src/libs/actions/IOU/SearchUpdate.ts

View workflow job for this annotation

GitHub Actions / typecheck 

Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'SearchResultDataType'.
accountID: fromAccountID,
count: (existingGroup?.count ?? 0) + 1,
total: (existingGroup?.total ?? 0) + (transaction.amount ?? 0),
currency: existingGroup?.currency ?? transaction.currency ?? CONST.CURRENCY.USD,
};

const newFlatFilters = currentSearchQueryJSON.flatFilters.filter((filter) => filter.key !== CONST.SEARCH.SYNTAX_FILTER_KEYS.FROM);
newFlatFilters.push({
key: CONST.SEARCH.SYNTAX_FILTER_KEYS.FROM,
Expand Down
Loading