-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Add highcontrast btn in signin page and sync it with server values #92117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rushatgabhane
wants to merge
6
commits into
Expensify:main
Choose a base branch
from
rushatgabhane:home-high-contrast
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
11040f9
add highcontrast btn in signin page and sync it with server values
rushatgabhane 7f87a7e
Apply suggestions from code review
rushatgabhane 60f88c0
add a11y label to icon
rushatgabhane 2069610
Merge branch 'home-high-contrast' of github.com:rushatgabhane/exfy in…
rushatgabhane e8db467
add maxwidth 150px
rushatgabhane 8f50409
fix lint
rushatgabhane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import React from 'react'; | ||
| import {View} from 'react-native'; | ||
| import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset'; | ||
| import useLocalize from '@hooks/useLocalize'; | ||
| import useOnyx from '@hooks/useOnyx'; | ||
| import useTheme from '@hooks/useTheme'; | ||
| import useThemeStyles from '@hooks/useThemeStyles'; | ||
| import {getBaseTheme, getContrastTheme, isHighContrastTheme} from '@styles/theme/utils'; | ||
| import variables from '@styles/variables'; | ||
| import {setHighContrastIntent, updateTheme} from '@userActions/User'; | ||
| import CONST from '@src/CONST'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import Icon from './Icon'; | ||
| import PressableWithFeedback from './Pressable/PressableWithFeedback'; | ||
| import Text from './Text'; | ||
|
|
||
| function HighContrastModeSwitcher() { | ||
| const theme = useTheme(); | ||
| const styles = useThemeStyles(); | ||
| const {translate} = useLocalize(); | ||
| const [preferredTheme] = useOnyx(ONYXKEYS.PREFERRED_THEME); | ||
| const icons = useMemoizedLazyExpensifyIcons(['Lightbulb']); | ||
|
|
||
| const currentTheme = preferredTheme ?? CONST.THEME.DEFAULT; | ||
| const isHighContrast = isHighContrastTheme(currentTheme); | ||
|
|
||
| const toggleHighContrast = () => { | ||
| const baseTheme = getBaseTheme(currentTheme); | ||
| updateTheme(isHighContrast ? baseTheme : getContrastTheme(baseTheme), false); | ||
| setHighContrastIntent(!isHighContrast); | ||
| }; | ||
|
|
||
| return ( | ||
| <PressableWithFeedback | ||
| onPress={toggleHighContrast} | ||
| sentryLabel="HighContrastModeSwitcher-Toggle" | ||
| role={CONST.ROLE.BUTTON} | ||
| accessibilityLabel={translate('themePage.enableHighContrast')} | ||
| accessibilityState={{checked: isHighContrast}} | ||
| wrapperStyle={styles.flex1} | ||
| style={[styles.flexRow, styles.alignItemsCenter]} | ||
| > | ||
| <Icon | ||
| src={icons.Lightbulb} | ||
| fill={isHighContrast ? theme.text : theme.icon} | ||
| width={variables.iconSizeSmall} | ||
| height={variables.iconSizeSmall} | ||
| accessibilityLabel={translate('themePage.enableHighContrast')} | ||
| /> | ||
| <View style={[styles.ml2, styles.flex1, styles.pickerContainer, styles.pickerContainerSmall]}> | ||
| <Text style={styles.textSmall}>{translate('themePage.enableHighContrast')}</Text> | ||
| </View> | ||
| </PressableWithFeedback> | ||
| ); | ||
| } | ||
|
|
||
| export default HighContrastModeSwitcher; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ CLEAN-REACT-PATTERNS-4 (docs)
The
AuthScreensInitHandlercomponent already aggregates multiple unrelated responsibilities (session management, Pusher initialization, navigation setup, app loading). This newuseEffectfor reconciling the high-contrast theme intent after sign-in is an unrelated concern that further adds to the mix. If the high-contrast reconciliation logic changes, it requires navigating through all the other unrelated effects in this component.Extract this effect into a focused custom hook, for example:
Then call
useReconcileHighContrastIntent()insideAuthScreensInitHandler(or in a separate component if appropriate), keeping the concern isolated and independently testable.Reviewed at: 7f87a7e | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Eskalifer1 lemme know if you agree with this and I'll change it.
Because I think it's probably fine to keep it in this file