[DO NOT MERGE] fix: IDB backing store corruption healing (onyx PR #780 test) by leshniak · Pull Request #91085 · Expensify/App

leshniak · 2026-05-19T14:09:43Z

Explanation of Change

THIS IS ONLY FOR TESTING PURPOSES, DO NOT MERGE (do a proper Onyx bump after merging the Onyx feature)

Pins react-native-onyx to PR #780 HEAD (3fbb6574) which adds an IDB backing store corruption healing mechanism. This is a test-only PR to validate the fix in Expensify/App context.

What PR #780 does:

Detects Chromium UnknownError: Internal error opening backing store (884K errors/month, 26.3% of all storage errors)
Detects Safari/WebKit connection lost and connection closing errors (637K errors/month, 19%)
Implements Dexie-style heal: drop cached IDB connection, reopen with fresh indexedDB.open(), budgeted to 3 attempts (reset on success)
Full diagnostic logging via Logger.logInfo for heal attempts and Logger.logAlert only for budget exhaustion / non-recoverable errors
No deleteDatabase(), no provider swap, no UI changes

Also removes stale react-native-onyx+3.0.73.patch — the changes it patched (reverting PR #770) already landed upstream in onyx 3.0.72 via PR #785, and our git pin includes that fix.

Fixed Issues

$ #90636
PROPOSAL:

Tests

Each test injects a monkey-patch via the browser console to simulate the error class, then triggers an Onyx write (e.g. navigate to a different chat). No code changes needed.

Test 1 — Backing store error (Chromium path):

Open the app in Chrome, log in, navigate to any chat

Open DevTools Console, paste:

const _origTx = IDBDatabase.prototype.transaction;
let _fired = false;
IDBDatabase.prototype.transaction = function(...args) {
  if (!_fired) {
    _fired = true;
    IDBDatabase.prototype.transaction = _origTx;
    throw new DOMException('Internal error opening backing store', 'UnknownError');
  }
  return _origTx.apply(this, args);
};

Navigate to a different chat (triggers Onyx write)
Filter console with regex: /IDB (heal|InvalidStateError|error|connection closed|Store \w+ does not exist|Creating store)/
Expected log sequence (via Log.ts):
- [info] IDB heal: backing store error detected — dropping cached connection and reopening (2 attempts left)
- [info] IDB heal: successfully recovered after backing store error
App recovers — navigation works, no white screen, subsequent operations succeed

Test 2 — Connection lost (Safari path):

Same setup as Test 1

Paste in DevTools Console:

const _origTx = IDBDatabase.prototype.transaction;
let _fired = false;
IDBDatabase.prototype.transaction = function(...args) {
  if (!_fired) {
    _fired = true;
    IDBDatabase.prototype.transaction = _origTx;
    throw new DOMException('Connection to Indexed Database server lost', 'UnknownError');
  }
  return _origTx.apply(this, args);
};

Navigate to a different chat
Expected log sequence:
- [info] IDB heal: connection lost error detected — dropping cached connection and reopening (2 attempts left)
- [info] IDB heal: successfully recovered after connection lost error
App recovers seamlessly

Test 3 — Budget exhaustion (3 consecutive failures, then gives up):

Same setup as Test 1

Paste in DevTools Console:

const _origTx = IDBDatabase.prototype.transaction;
let _count = 0;
IDBDatabase.prototype.transaction = function(...args) {
  if (_count < 6) {
    _count++;
    throw new DOMException('Internal error opening backing store', 'UnknownError');
  }
  IDBDatabase.prototype.transaction = _origTx;
  return _origTx.apply(this, args);
};

Navigate to a different chat
Expected log sequence:
- [info] IDB heal: backing store error detected — dropping cached connection and reopening (2 attempts left)
- [info] IDB heal: backing store error detected — dropping cached connection and reopening (1 attempts left)
- [info] IDB heal: backing store error detected — dropping cached connection and reopening (0 attempts left)
- [alrt] IDB heal: backing store error — heal budget exhausted, giving up
Onyx's setWithRetry takes over (up to 5 retries). App may degrade but should not crash or white-screen

Verify that no errors appear in the JS console

Offline tests

N/A — this change targets IDB connection/corruption errors, not network state. Onyx's existing offline handling is unchanged.

QA Steps

Same as Tests section above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A — IDB is web-only, no native changes.

Android: mWeb Chrome

iOS: Native

N/A — IDB is web-only, no native changes.

iOS: mWeb Safari

MacOS: Chrome / Safari

Healed (simulated error):

healed.mov

Killed connection (simulated error):

killed.mp4

Exhausted (simulated error):

exhausted.mov

Healed (simulated on Safari):

safari_error.mp4

Killed connection (simulated on Safari):

safari_killed.mp4

Exhausted (simulated on Safari):

safari_exhausted.mp4

Healed offline (simulated on Chrome):

offline.mp4

Pin onyx to Expensify/react-native-onyx#780 (commit beb75d5f) which adds IDB backing store corruption healing. Remove stale 3.0.71 patch (already reverted upstream in 3.0.72 via PR Expensify#785). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions · 2026-05-19T14:11:00Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…heal-test # Conflicts: # package-lock.json # package.json # patches/react-native-onyx/details.md # patches/react-native-onyx/react-native-onyx+3.0.73.patch

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Remove initWithStoredValues usage (removed in onyx 3.0.74 via PR Expensify#782) and unused getKeywordQueryWithCurrentSearchContext import. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

codecov · 2026-05-26T15:02:19Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...oks/useClearSelectedDomainMembersOnMoveComplete.ts	`0.00% <0.00%> (ø)`
... and 451 files with indirect coverage changes

melvin-bot · 2026-05-26T15:11:18Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ikevin127 · 2026-05-27T00:54:23Z

@Julesssss Please tag me if my C+ review is needed in case there wasn't a C+ already assigned to this effort 🙌

Julesssss · 2026-05-27T17:13:30Z

@Julesssss Please tag me if my C+ review is needed in case there wasn't a C+ already assigned to this effort 🙌

Please go ahead @ikevin127, for this review there is an associated Onyx PR for review too, combined into one.

ikevin127 · 2026-05-27T23:46:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome

chrome.mov

MacOS: Safari

safari.mov

ikevin127 · 2026-05-28T00:14:27Z

 */
 function useClearSelectedDomainMembersOnMoveComplete(clearSelectedMembers: () => void) {
-    const [selectedMemberAccountIDs] = useOnyx(ONYXKEYS.DOMAIN_MEMBERS_SELECTED_FOR_MOVE, {initWithStoredValues: false});
+    const [selectedMemberAccountIDs] = useOnyx(ONYXKEYS.DOMAIN_MEMBERS_SELECTED_FOR_MOVE);


🟡 CRITICAL ISSUE - Unexplained behavioral change

The PR description does not explain why initWithStoredValues: false was removed. This option controls the initial render behavior:

false: Hook starts in loading state, value is undefined until Onyx connects

true (default): Hook immediately returns the stored value

Bug this could cause: If this hook is used during app initialization when DOMAIN_MEMBERS_SELECTED_FOR_MOVE may already have a stale value from a previous session,
removing initWithStoredValues: false means the hook will read that stale value immediately.

If there's logic that depends on the transition from "no selection" → "has selection" or vice versa, using the stale initial value could incorrectly trigger clearSelectedMembers() on mount.

Suggested fix: If this change is intentional (e.g., the new onyx version changes how initWithStoredValues works, or the hook was incorrectly using it), we could add a comment or note in the PR explaining why it was removed. If it's not intentional, we should revert it.

ikevin127 · 2026-05-28T00:18:00Z

        const connectionID = Onyx.connect({
            key: ONYXKEYS.NVP_TRY_NEW_DOT,
-            initWithStoredValues: true,
+


Formatting: There's a blank line left where the property was.

ikevin127 · 2026-05-28T00:44:31Z

🔴 I got an UnknownError on Test 3, Step 5 (see video below)

1. Onyx's setWithRetry takes over (up to 5 retries). App may degrade but should not crash or white-screen

Is this expected ?

test-3-error.mov

leshniak · 2026-05-28T14:17:46Z

@ikevin127 sorry for not mentioning this before - this is not a PR to merge, just an env for testing the Onyx change. If Onyx looks fine, we'll incorporate it to the app via proper Onyx bump.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

melvin-bot Bot assigned leshniak May 19, 2026

leshniak mentioned this pull request May 19, 2026

fix: add IDB healing mechanism for backing store corruption and connection lost errors Expensify/react-native-onyx#780

Open

42 tasks

leshniak and others added 7 commits May 20, 2026 13:22

fix: update onyx pin to latest Expensify#780 HEAD (d1f95a03)

545b878

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: update onyx pin to ca5c2b14 (improved diagnostic logging)

0766c18

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: update onyx pin to e6c812e1 (prettier + probe timing fix)

52fafa0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: update onyx pin to 92405996 (heal logs downgraded to info level)

52365e2

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Merge remote-tracking branch 'upstream/main' into fix/idb-corruption-…

c95b733

…heal-test # Conflicts: # package-lock.json # package.json # patches/react-native-onyx/details.md # patches/react-native-onyx/react-native-onyx+3.0.73.patch

fix: reset Mobile-Expensify submodule to upstream/main

505911b

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

fix: resolve typecheck and eslint errors from pinned onyx version

97ce738

Remove initWithStoredValues usage (removed in onyx 3.0.74 via PR Expensify#782) and unused getKeywordQueryWithCurrentSearchContext import. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

leshniak marked this pull request as ready for review May 26, 2026 15:11

leshniak requested review from a team as code owners May 26, 2026 15:11

melvin-bot Bot requested review from flaviadefaria and ikevin127 and removed request for a team and ikevin127 May 26, 2026 15:11

Julesssss self-requested a review May 26, 2026 23:25

leshniak mentioned this pull request May 27, 2026

[Onyx] Investigate UnknownError: Internal error opening backing store for indexedDB.open. storage error #87862

Open

Julesssss requested a review from ikevin127 May 27, 2026 17:13

ikevin127 reviewed May 28, 2026

View reviewed changes

leshniak changed the title ~~fix: IDB backing store corruption healing (onyx PR #780 test)~~ [DO NOT MERGE] fix: IDB backing store corruption healing (onyx PR #780 test) May 28, 2026

fix: bump onyx pin to 6445eaac (DOMException detection fix)

c33d35e

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] fix: IDB backing store corruption healing (onyx PR #780 test)#91085

[DO NOT MERGE] fix: IDB backing store corruption healing (onyx PR #780 test)#91085
leshniak wants to merge 9 commits into
Expensify:mainfrom
callstack-internal:fix/idb-corruption-heal-test

leshniak commented May 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

codecov Bot commented May 26, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented May 26, 2026

Uh oh!

ikevin127 commented May 27, 2026

Uh oh!

Julesssss commented May 27, 2026

Uh oh!

ikevin127 commented May 27, 2026 •

edited

Loading

Uh oh!

ikevin127 May 28, 2026

Uh oh!

ikevin127 May 28, 2026

Uh oh!

ikevin127 commented May 28, 2026

Uh oh!

leshniak commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

leshniak commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

THIS IS ONLY FOR TESTING PURPOSES, DO NOT MERGE (do a proper Onyx bump after merging the Onyx feature)

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

codecov Bot commented May 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 26, 2026

Uh oh!

ikevin127 commented May 27, 2026

Uh oh!

Julesssss commented May 27, 2026

Uh oh!

ikevin127 commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ikevin127 May 28, 2026

Choose a reason for hiding this comment

🟡 CRITICAL ISSUE - Unexplained behavioral change

Uh oh!

ikevin127 May 28, 2026

Choose a reason for hiding this comment

Uh oh!

ikevin127 commented May 28, 2026

Uh oh!

leshniak commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leshniak commented May 19, 2026 •

edited

Loading

codecov Bot commented May 26, 2026 •

edited by github-actions Bot

Loading

ikevin127 commented May 27, 2026 •

edited

Loading