Skip to content

MID-10908 Fix tooltip lifecycle in search popovers #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kay1313 wants to merge 4 commits into
base: master
Choose a base branch
from
+23 −11
Open

MID-10908 Fix tooltip lifecycle in search popovers #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9ea006
MID-10908 Fix tooltip lifecycle in search popovers
kay1313 May 22, 2026
8fa19bb
MID-10908 Fix tooltip placement in search popover
kay1313 Jun 10, 2026
f212d69
merge origin/master
1azyman Jun 12, 2026
e4f97cf
Merge remote-tracking branch 'origin/master' into fix/MID-10908
1azyman Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions gui/admin-gui/src/frontend/js/midpoint-theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,11 +302,11 @@ export default class MidPointTheme {
if (parentMorePopup && parentMorePopup.length !== 0) {
setTimeout(function() {
isHovered = false;
checkHide($(this));
checkHide($el);
}, 300);
} else {
isHovered = false;
checkHide($(this));
checkHide($el);
}
});

Expand Down Expand Up @@ -364,13 +364,21 @@ export default class MidPointTheme {
const tooltipId = 'tooltip-' + Math.random().toString(16).substr(2, 6);
$el.attr('data-tooltip-id', tooltipId);

$el.tooltip({
const tooltipOptions = {
html: true,
title: $el.attr('data-tooltip-content') || '',
whiteList: wl,
container: container,
trigger: 'manual'
});
};

if ($el.closest('.search-popover').length !== 0) {

@1azyman 1azyman Jun 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be handled somewhere in SelectableItemListPopoverPanel:164? This is "generic" tooltip handling, options should be passed from caller if possible, otherwise we'll end up with random conditions here. Maybe InfoTooltipBehavior.getDataPlacement() is not enough and has to be extended to more options...

tooltipOptions.placement = 'left';
tooltipOptions.boundary = 'window';
tooltipOptions.offset = '0, 2';
}

$el.tooltip(tooltipOptions);

// "tooltipShowDelayTimer" is used to prevent tooltip from showing when user quickly moves mouse
// over multiple icons with tooltips or quickly tabs through them. Tooltip will be shown only for
Expand All @@ -379,13 +387,13 @@ export default class MidPointTheme {
$el.data("tooltipShowDelayTimer", setTimeout(() => {
$el.tooltip("show");
$el.removeAttr("aria-describedby");
}, 1000));

setTimeout(() => {
const $tooltip = $('.tooltip:visible').last();
$tooltip.removeAttr('role');
const $tooltip = $('.tooltip:visible').last()
.attr('id', tooltipId)
.removeAttr('role');
if (!setFocus) {
$tooltip.css('pointer-events', 'none');
}
const $tooltipInner = $tooltip.find('.tooltip-inner');
$tooltip.attr('id', tooltipId);

$tooltipInner
.attr('tabindex', '0')
Expand Down Expand Up @@ -428,7 +436,7 @@ export default class MidPointTheme {
$tooltipInner.focus();
lastTooltipTrigger = $el;
}
}, 100);
}, 1000));
}
};

Expand Down Expand Up @@ -1389,6 +1397,9 @@ export default class MidPointTheme {

if (!show) {
if (popup.is(':visible')) {
popup.find("[data-toggle='tooltip']").each(function () {
$(this).tooltip('hide').tooltip('dispose').removeAttr('data-tooltip-id aria-describedby');
});
popup.fadeOut(200);
ref.attr('aria-expanded', 'false');
ref.focus();
Expand Down
1 change: 1 addition & 0 deletions release-notes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ Overall, midPoint 4.10 opens up the world of identity management and governance
* Fixed missing input variable in resource activation existence mappings. See bug:MID-10905[]
* Fixed stale page recovery after viewing page source causing internal server error. See bug:MID-9998[]
* Hided conflict warning on Shopping cart panel of the Request Access wizard in case of prune action. See bug:MID-11250[] and xref:#_behavior_changes_since_4_10[behavior changes since 4.10].
* Fixed tooltip lifecycle in search popovers to prevent blinking, stuck, and duplicate tooltips. See bug:MID-10908[]

=== Releases Of Other Components

Expand Down
Loading