purefb_server: add local_directory_service and modernize version gate - #579
Open
ananthakrishnanvk wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds
local_directory_servicetopurefb_serverand modernizes the module's REST API version gate.Key changes:
local_directory_service(str) - Wired into both the create path (ServerPost) and the update path (Serverpatch). The update diff reads the current value viagetattr(server_info, "local_directory_service", None).nameand only patches when it differs.add_serverrefactored - the old 2^Nif/elifmatrix (dns × directory_service) is replaced by a smallserver_kwargsdict that composes cleanly with the new third option. Behavior is unchanged for the two existing options; the new option slots in without adding another branch.LooseVersionISSUE TYPE
COMPONENT NAME
purefb_serverADDITIONAL INFORMATION
579_purefb_server_local_directory_service.yaml.