fix: add missing dependency to video quickstart#39
Open
DieselZhang wants to merge 1 commit into
Open
Conversation
The video quickstart now declares typing-extensions explicitly so uv can create a complete isolated script environment and import daft successfully. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello maintainers,
I hope you are doing well. I noticed that running the video quickstart with
uv run quickstart/05_video_file.pycurrently fails in a fresh isolated script environment becausetyping_extensionsis not installed, even though Daft imports it at runtime.This PR makes a very small change by declaring
typing-extensionsexplicitly in the script metadata forquickstart/05_video_file.py. After this change, the example runs successfully withuv.Summary
typing-extensionsto the video quickstart script dependenciesuv run quickstart/05_video_file.pyworks in a clean isolated environmentTest plan
uv run quickstart/05_video_file.pysuccessfullyuv run ruff check .successfullyuv run ruff format --check .successfullyThank you very much for considering this contribution. I would be grateful if you could review it when convenient, and I would be happy to make any adjustments if needed.