Feat/enhance make dx#93
Open
moodyjmz wants to merge 6 commits into
Open
Conversation
After `docker compose up -d`, check if the nextcloud container failed to start due to a version mismatch and print a clear message with the fix rather than hanging silently in refresh-urls. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Replace the anonymous /var/www/html volume with a named volume keyed on NC_VERSION (default: latest). This mirrors the make next pattern, giving each pinned version its own isolated state. The NC entrypoint auto-runs occ upgrade when the image advances, so pulling a newer latest and restarting is safe without manual intervention. Note: existing anonymous volumes are orphaned by this change — NC will reinstall cleanly into the new named volume on first boot. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Replace fixed timeouts with container status checks — bail immediately if eo or nextcloud exits unexpectedly, with a pointer to the logs. After 1000s, tail the last nextcloud log line so slow first-boot installs (e.g. make next) show live progress instead of a silent counter. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
next-mobile mirrors make mobile for make next branches, injecting the detected HOST_LAN_IP for Android emulator and LAN device testing. wipe-nc and wipe-next stop the nextcloud container then remove the named data volume for the current NC_VERSION or NC_BRANCH respectively, giving a clean path to reinstall without touching other versions. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Show full Nextcloud URL in mobile mode instead of bare IP, display the active volume name with an exact wipe command, and use NC_VERSION in the stale-image warning so pinned versions get the correct pull command. Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
…t-mobile - Fix stale JWT secret (was 'secret', now the actual dev key) - Document NC_VERSION pinning and nc_data_<version> volume isolation - Replace manual docker volume rm with make wipe-nc / make wipe-next - Add make next-mobile to mobile testing table and description - Mention live log tailing during slow first-boot installs - Note the stale-image detection and auto-upgrade on make local Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make dev setup more robust and provide more useful feedback
Doesn't delete data volumes when switching to support different NC versions
Provides feedback if install is taking a long time
Provides feature to wipe targets
Adds
make next-mobile- akin tomake next