Add placevr capture model with template validation, tests, and demo main#2
Open
EthanForAi wants to merge 1 commit into
Open
Add placevr capture model with template validation, tests, and demo main#2EthanForAi wants to merge 1 commit into
EthanForAi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
main.goto build a sample node, populate shots, validate, and emit JSON for integration testing.Description
placevrpackage withcapture.godefiningMaxShotsPerNode,CaptureTemplate,GuideSlot,Shot, andNodetypes and validation logic includingDefaultTemplateV1,CaptureTemplate.Validate,Node.Validate,Node.AddShot, andNode.IsReadyForUpload.placevr/capture_test.gocovering the default template validation and preventing adding more thanMaxShotsPerNodeshots.main.goto create a demoNode, populate it with shots up toMaxShotsPerNode, validate it, marshal it to JSON, and print upload readiness.go.modwith moduleplacevrandgo 1.22.Testing
go test ./..., and the tests completed successfully.Codex Task