fix(placement): keep seed cleanup summary consistent

[EtanHey]

Summary

• record a completed role-placement move before post-move validation or seed cleanup can fail
• keep seed-cleanup failures from counting the same agent as both moved and skipped
• document why spawn-trigger membership is sufficient before launch

Scope

PR-3.5 follow-up from #329. No placement mutation, provenance, resync, or sidebar-render behavior changes.

Verification

• RED: missing seed UUID regression initially produced both moved and skipped
• tests/agent-engine.test.ts: 265 passed
• hermetic full suite: 104 files / 2203 tests passed
• bun run typecheck
• bun run build
• local CodeRabbit rereview: 0 findings
• pre-push nightly contract runner and full hermetic suite passed

Note

Fix seed cleanup summary in AgentEngine.reconcileRolePlacements to suppress duplicate skipped entries

When a seed cleanup or post-move assertion fails for an agent already recorded in summary.moved, the method was incorrectly adding that agent to summary.skipped as well. A guard now checks summary.moved before adding a skipped entry, keeping the move result intact. The epoch assertion is also reordered to run after the move is recorded.

^{Macroscope summarized 3c86c45.}

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_8ae1a51d-5520-4daf-aaad-0d945b1ef710)

[coderabbitai]

Warning

Review limit reached

@EtanHey, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1fa646d0-3a8f-4ab7-aa7a-b01377bb9ce9

📥 Commits

Reviewing files that changed from the base of the PR and between f9f57b4 and 3c86c45.

📒 Files selected for processing (2)

• src/agent-engine.ts
• tests/agent-engine.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/pr35-seed-cleanup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[EtanHey]

@coderabbitai review

[EtanHey]

@codex review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 3c86c455e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".