fix(release): hermeticize v0.4.14 release verification#331
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_6b28180b-e421-4def-87c2-ede4a5702d48) |
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
@codex review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf38a17015
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo "release: gating on typecheck + tests…" | ||
| run "bun run typecheck" | ||
| run "bun run test" | ||
| run "env -u CMUX_SOCKET_PATH -u CMUX_DAEMON_SOCKET bun run test" |
There was a problem hiding this comment.
Unset the actual daemon socket env var
This removes CMUX_DAEMON_SOCKET, but the codebase reads CMUXLAYER_DAEMON_SOCKET for daemon socket overrides (src/daemon-socket-path.ts and the existing nightly contract wrapper use that name). When a developer has CMUXLAYER_DAEMON_SOCKET exported, the release gate still inherits the live daemon override, so the supposedly hermetic bun run test path can bind/probe the ambient daemon socket; the pre-push hook has the same typo. Please unset CMUXLAYER_DAEMON_SOCKET here and in .githooks/pre-push.
Useful? React with 👍 / 👎.
Summary
Test plan
Review notes
Note
Low Risk
Changes are limited to release/docs/scripts and test harness env hygiene; no runtime product logic.
Overview
Release and pre-push gates now run the default test suite with
CMUX_SOCKET_PATHandCMUX_DAEMON_SOCKETunset so local cmux pins cannot make CI-like gates non-deterministic. The opt-intest:contractlane inrelease.shis unchanged and still runs after the hermetic gate.Post-release verification adds
scripts/release-verify.sh, which hard-resets Homebrew's tap clone atLibrary/Taps/etanhey/homebrew-layerstoorigin/main, runsbrew upgrade, and fails unlessbrew list --versionsmatches the released semver.release.shanddocs/releases-and-brew.mdpoint operators at this helper instead of relying onbrew updatealone when the tap'soriginis a local checkout without upstream tracking.Tests extend
pre-pr-scripts.test.tsto lock in the env-unset hooks, hermetic release gate, and release-verify wiring.Reviewed by Cursor Bugbot for commit cf38a17. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add hermetic release verification script for v0.4.14 and unset CMUX env vars in test gates
scripts/release-verify.shthat syncs the Homebrew tap clone viagit fetch/git reset --hard origin/main, runsbrew upgrade etanhey/layers/cmuxlayer, and exits non-zero if the installed version doesn't exactly match the specified semver argument.scripts/release.shand.githooks/pre-pushto unsetCMUX_SOCKET_PATHandCMUX_DAEMON_SOCKETbefore running tests, preventing ambient socket state from affecting test results.docs/releases-and-brew.mdto include the new verification script in the release workflow.tests/pre-pr-scripts.test.tscovering the hermetic env-unset invocations and the release verification script's tap sync and version assertion logic.📊 Macroscope summarized cf38a17. 4 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.