fix: Propagates live_print_scope to shell message_callbacks#20
Merged
EspenAlbert merged 2 commits intoJun 1, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 86.27% 86.29% +0.01%
==========================================
Files 22 22
Lines 2084 2087 +3
==========================================
+ Hits 1798 1801 +3
Misses 286 286 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
live_print_scopenot reachingmessage_callbacksbecause shell streaming runs on pool threads without the caller'scontextvars.What changed
ShellRuncapturescontextvars.copy_context()at construction._on_eventinside that snapshot so callbacks (andprint_to_livefrom them) see the caller's scope.run_and_wait/message_callbackspropagation and snapshot semantics.Reviewer notes
ShellRuncreation is intentional: scope is fixed for the run (including retries), not updated mid-flight.ShellRunBeforestill runs outside the snapshot on the_execute_runthread; only queue-driven callbacks are in scope (matches tfdo stream-handler path).[run_dir_key]prefixes in apply renderers can stay as defense-in-depth; orchestration may restorelive_print_scopefor non-renderer paths once this ships.Test plan
just pre-commit-asklive_print_scopeatrun_and_waittime