feat: Adds support for live print context and run_pool context propagation#19
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 85.89% 86.27% +0.38%
==========================================
Files 21 22 +1
Lines 2042 2084 +42
==========================================
+ Hits 1754 1798 +44
+ Misses 288 286 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds scoped metadata for live-console scroll lines so tfdo multi-directory orchestration can prefix or suppress
print_to_live/log_to_liveper run directory without touching every call site.What changed
LivePrintContext+live_print_scope()onask_shell.console: optionalprefixandsuppressviacontextvars.print_to_live/log_to_live: honor active scope (prepend prefix; skip output when suppressed).run_pool.submit: captures submit-time context withcopy_context()so worker threads see the same scope.Reviewer notes
copy_contexton everysubmit: small per-task cost; intended for orchestration-scale parallelism, not hot loops with thousands of submits.style; markup inprefixis caller responsibility.styleonLivePrintContextdeferred; add later if tfdo needs dim per-dir lines without per-callstyle=.