Add %texture_hash% for avatar URLs - #48
Open
knot126 wants to merge 2 commits into
Open
Conversation
Known bugs: - %texture_hash% causes the connection test to fail because it doesn't condsider %texture_hash% atm. This means if testing is enabled, it only works if used in the fallback. - Probably broke something else I haven't realised
knot126
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
%texture_hash%in avatar URLs, which can be used with dynamic skin changing tools (ex SkinRestorer) which are useful with offline servers. Also refactored how the avatar URL is made so it's not in 1000 different places.Also see the PR in DiscordIntegration-Core which makes the skin API availability check work.
Sorry if anything here is bad, I'm not a good Java programmer. Also I'm not sure exactly how I should go about backporting this for the other versions so it's just 26.2 for now.