fix: replace hardcoded light-mode colors with CSS variables for consistent dark theme (Closes #152) - #213
Merged
Conversation
…stent dark theme (Closes Epta-Node#152)
|
@water is attempting to deploy a commit to the Jaja's projects Team on Vercel. A member of the Team first needs to authorize it. |
devJaja
self-requested a review
July 29, 2026 20:23
devJaja
approved these changes
Jul 29, 2026
devJaja
left a comment
Contributor
There was a problem hiding this comment.
Solid implementation @waterWang
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the dark/light theme inconsistency where dashboard and wallet components rendered with light-mode colors inside a dark-themed layout shell.
Changes
Added CSS variables (global.css)
--bg-secondary: #1A1F2E— secondary background color for surfaces--border-color: #2A3040— border color for cards and dividersUpdated CSS module files
Replaced hardcoded light-mode colors with theme-aware CSS variables across 7 CSS module files:
KpiCard.module.css#ffffff→var(--bg-primary),#0f172a→var(--text-primary), skeleton shimmer colorsNetworkHealthBadge.module.css#374151→var(--text-secondary)RecentTasksTable.module.css#f8fafc→var(--bg-secondary),#e2e8f0→var(--border-color),#64748b→var(--text-secondary)SendXLMForm.module.css#ffffff→var(--bg-primary),#f8fafc→var(--bg-secondary), border colors, text colorsTransactionTable.module.css#ffffff→var(--bg-primary),#f8fafc→var(--bg-secondary), skeleton colorsWalletPage.module.css#ffffff→var(--bg-primary),#f8fafc→var(--bg-secondary), border/text colorsTaskSubmissionForm.tsx#cbd5e1borders →var(--border-color),#f8fafc→var(--bg-secondary)Color mapping
#ffffffvar(--bg-primary)#f8fafcvar(--bg-secondary)#0f172avar(--text-primary)#374151/#64748bvar(--text-secondary)#cbd5e1/#e2e8f0var(--border-color)Testing
@stellar/stellar-sdkmodule resolution)Closes #152