Skip to content

fix: replace hardcoded light-mode colors with CSS variables for consistent dark theme (Closes #152) - #213

Merged
devJaja merged 1 commit into
Epta-Node:mainfrom
waterWang:fix/dark-light-theme-mixing
Jul 29, 2026
Merged

fix: replace hardcoded light-mode colors with CSS variables for consistent dark theme (Closes #152)#213
devJaja merged 1 commit into
Epta-Node:mainfrom
waterWang:fix/dark-light-theme-mixing

Conversation

@waterWang

Copy link
Copy Markdown

Summary

Fixes the dark/light theme inconsistency where dashboard and wallet components rendered with light-mode colors inside a dark-themed layout shell.

Changes

Added CSS variables (global.css)

  • --bg-secondary: #1A1F2E — secondary background color for surfaces
  • --border-color: #2A3040 — border color for cards and dividers

Updated CSS module files

Replaced hardcoded light-mode colors with theme-aware CSS variables across 7 CSS module files:

File Changes
KpiCard.module.css #ffffffvar(--bg-primary), #0f172avar(--text-primary), skeleton shimmer colors
NetworkHealthBadge.module.css #374151var(--text-secondary)
RecentTasksTable.module.css #f8fafcvar(--bg-secondary), #e2e8f0var(--border-color), #64748bvar(--text-secondary)
SendXLMForm.module.css #ffffffvar(--bg-primary), #f8fafcvar(--bg-secondary), border colors, text colors
TransactionTable.module.css #ffffffvar(--bg-primary), #f8fafcvar(--bg-secondary), skeleton colors
WalletPage.module.css #ffffffvar(--bg-primary), #f8fafcvar(--bg-secondary), border/text colors
TaskSubmissionForm.tsx Inline #cbd5e1 borders → var(--border-color), #f8fafcvar(--bg-secondary)

Color mapping

Hardcoded CSS Variable
#ffffff var(--bg-primary)
#f8fafc var(--bg-secondary)
#0f172a var(--text-primary)
#374151 / #64748b var(--text-secondary)
#cbd5e1 / #e2e8f0 var(--border-color)

Testing

  • ✅ 39 tests passed across 6 test files
  • 2 pre-existing failures unrelated to this change (@stellar/stellar-sdk module resolution)
  • Verified TypeScript compilation has no new errors

Closes #152

@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

@water is attempting to deploy a commit to the Jaja's projects Team on Vercel.

A member of the Team first needs to authorize it.

@devJaja
devJaja self-requested a review July 29, 2026 20:23

@devJaja devJaja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid implementation @waterWang

LGTM

@devJaja
devJaja merged commit ef16220 into Epta-Node:main Jul 29, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Fix Dark/Light Theme Mixing: Dashboard Components Render Light Mode Inside Dark Shell

2 participants