fix: fixes hideEmpty not returning routes when no filter is provided#183
Merged
Conversation
Eomm
reviewed
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
hideEmptydropping routes when noroutesFilteris providedProblem
When calling
app.overview({ hideEmpty: true })without aroutesFilter, all routes were silently dropped from the output — even when routes existed on the encapsulation context.The root cause is in the
handleRoutesfunction inlib/utils.js. This function is called from theJSON.stringifyreplacer insidefilterStructure. The previous code had two branches:opts.routesFilteris set, filter and return the routes (orundefinedif the filtered result is empty andhideEmptyis on).opts.hideEmptyis set andvalue.length === 0, returnundefined.When
hideEmpty: truewas set but noroutesFilterwas provided, and the routes array was non-empty, the function fell through both branches without hitting anyreturnstatement — implicitly returningundefined. SinceJSON.stringifyomits keys whose replacer returnsundefined, theroutesproperty was stripped from the output entirely.Fix
Added an explicit return of the routes array when it is non-empty and no
routesFilteris provided:This ensures the
handleRoutesfunction covers all code paths:routesFilterhideEmptyundefinedundefinedundefined(bug)undefinedundefinedundefined(bug)Example
Test coverage
Added a dedicated test case (
'hide empty with no routes filter') that registers routes on the root instance, callsapp.overview({ hideEmpty: true })without aroutesFilter, and asserts the routes are present in the output.