Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @assert shardy_passes in [:none, :to_mhlo_shardings, :post_sdy_propagation] | ||
| end | ||
|
|
||
| emulate_complex_val = emulate_complex === nothing ? (client === nothing ? false : !XLA.supports_complex(client)) : emulate_complex |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| emulate_complex_val = emulate_complex === nothing ? (client === nothing ? false : !XLA.supports_complex(client)) : emulate_complex | |
| emulate_complex_val = if emulate_complex === nothing | |
| (client === nothing ? false : !XLA.supports_complex(client)) | |
| else | |
| emulate_complex | |
| end |
| mod = MLIR.IR.Module(MLIR.IR.Location()) | ||
|
|
||
| compile_options, kwargs_inner = __get_compile_options_and_kwargs(; kwargs...) | ||
| compile_options, kwargs_inner = __get_compile_options_and_kwargs(; client, kwargs...) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| compile_options, kwargs_inner = __get_compile_options_and_kwargs(; client, kwargs...) | |
| compile_options, kwargs_inner = __get_compile_options_and_kwargs(; | |
| client, kwargs... | |
| ) |
| @test c == ones(ComplexF32, 2) + ones(ComplexF32, 2) | ||
| end | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| client::Client, array::Base.StridedArray{T,N}, sharding | ||
| ) where {T<:Reactant.ReactantPrimitive,N} | ||
| if T <: Complex && !XLA.supports_complex(client) | ||
| @assert sharding isa Reactant.Sharding.NoSharding || sharding isa Reactant.Sharding.Replicated |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @assert sharding isa Reactant.Sharding.NoSharding || sharding isa Reactant.Sharding.Replicated | |
| @assert sharding isa Reactant.Sharding.NoSharding || | |
| sharding isa Reactant.Sharding.Replicated |
Comment on lines
107
to
113
| MLIR.API.UninitPJRTBuffer( | ||
| client.client, | ||
| device.device, | ||
| XLA.primitive_type(S), | ||
| length(dims), | ||
| collect(Int64, reverse(dims)), | ||
| ptype, | ||
| ndims, | ||
| sizear, | ||
| ), |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| MLIR.API.UninitPJRTBuffer( | |
| client.client, | |
| device.device, | |
| XLA.primitive_type(S), | |
| length(dims), | |
| collect(Int64, reverse(dims)), | |
| ptype, | |
| ndims, | |
| sizear, | |
| ), | |
| MLIR.API.UninitPJRTBuffer(client.client, device.device, ptype, ndims, sizear) |
|
|
||
| result = try | ||
| process_linear_args!(linear_args, fnbody, do_transpose, optimize_then_pad, inv_map) | ||
| process_linear_args!(linear_args, fnbody, do_transpose, optimize_then_pad, inv_map, emulate_complex) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| process_linear_args!(linear_args, fnbody, do_transpose, optimize_then_pad, inv_map, emulate_complex) | |
| process_linear_args!( | |
| linear_args, | |
| fnbody, | |
| do_transpose, | |
| optimize_then_pad, | |
| inv_map, | |
| emulate_complex, | |
| ) |
| end | ||
|
|
||
| function process_linear_args!(linear_args, fnbody, do_transpose, optimize_then_pad, inv_map) | ||
| function process_linear_args!(linear_args, fnbody, do_transpose, optimize_then_pad, inv_map, emulate_complex) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function process_linear_args!(linear_args, fnbody, do_transpose, optimize_then_pad, inv_map, emulate_complex) | |
| function process_linear_args!( | |
| linear_args, fnbody, do_transpose, optimize_then_pad, inv_map, emulate_complex | |
| ) |
| end | ||
| end | ||
| set_mlir_data!(arg, row_maj_arg) | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Comment on lines
+641
to
+642
|
|
||
| start_real = ones(Int, N+1) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| start_real = ones(Int, N+1) | |
| start_real = ones(Int, N + 1) |
| start_real = ones(Int, N+1) | ||
| limit_real = collect(Int, sz) | ||
| pushfirst!(limit_real, 1) | ||
| start_imag = ones(Int, N+1) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| start_imag = ones(Int, N+1) | |
| start_imag = ones(Int, N + 1) |
Comment on lines
+649
to
+651
|
|
||
| traced_raw = TracedRArray{T2, N+1}((), row_maj_arg, (2, sz...)) | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| traced_raw = TracedRArray{T2, N+1}((), row_maj_arg, (2, sz...)) | |
| traced_raw = TracedRArray{T2,N + 1}((), row_maj_arg, (2, sz...)) | |
|
|
||
| real_slice = Ops.slice(traced_raw, start_real, limit_real) | ||
| imag_slice = Ops.slice(traced_raw, start_imag, limit_imag) | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
|
|
||
| real_part = Ops.reshape(real_slice, sz...) | ||
| imag_part = Ops.reshape(imag_slice, sz...) | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| (; sym_name, mesh_attr) = mesh_cache[key] | ||
| T = Reactant.unwrapped_eltype(arg) | ||
| if T <: Complex && emulate_complex | ||
| sharding = Reactant.adapt_sharding_for_emulated_complex(sharding, ndims(arg)) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| sharding = Reactant.adapt_sharding_for_emulated_complex(sharding, ndims(arg)) | |
| sharding = Reactant.adapt_sharding_for_emulated_complex( | |
| sharding, ndims(arg) | |
| ) |
| end | ||
| return true | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| finalize(mod) | ||
|
|
||
| return exec, hlo_modules, mlir_fn_res, device, client, module_string | ||
| return exec, hlo_modules, mlir_fn_res, device, client, module_string, compile_options |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return exec, hlo_modules, mlir_fn_res, device, client, module_string, compile_options | |
| return exec, | |
| hlo_modules, mlir_fn_res, device, client, module_string, | |
| compile_options |
mofeing
approved these changes
Jun 8, 2026
mofeing
left a comment
mofeing
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, but don't we take the size for some TracedRArray from MLIR's type inference for some op in Ops? in such case, it would we wrong for emulated complex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.