Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+1609
to
+1612
| const ReactantCUDACompilerConfig = CompilerConfig{ReactantPTXCompilerTarget{ReactantPTXBackend}, CUDACompilerParams} | ||
| const ReactantCUDACompilerJob = CompilerJob{ReactantPTXCompilerTarget{ReactantPTXBackend},CUDACompilerParams} | ||
|
|
||
| GPUCompiler.optimization_options(job::ReactantCUDACompilerJob) = (; instcombine=!job.config.target.raising, ptxfastmath=!job.config.target.raising) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| const ReactantCUDACompilerConfig = CompilerConfig{ReactantPTXCompilerTarget{ReactantPTXBackend}, CUDACompilerParams} | |
| const ReactantCUDACompilerJob = CompilerJob{ReactantPTXCompilerTarget{ReactantPTXBackend},CUDACompilerParams} | |
| GPUCompiler.optimization_options(job::ReactantCUDACompilerJob) = (; instcombine=!job.config.target.raising, ptxfastmath=!job.config.target.raising) | |
| const ReactantCUDACompilerConfig = CompilerConfig{ | |
| ReactantPTXCompilerTarget{ReactantPTXBackend},CUDACompilerParams | |
| } | |
| const ReactantCUDACompilerJob = CompilerJob{ | |
| ReactantPTXCompilerTarget{ReactantPTXBackend},CUDACompilerParams | |
| } | |
| function GPUCompiler.optimization_options(job::ReactantCUDACompilerJob) | |
| return (; | |
| instcombine=!job.config.target.raising, ptxfastmath=!job.config.target.raising | |
| ) | |
| end |
| debuginfo = false | ||
| config = GPUCompiler.CompilerConfig( | ||
| GPUCompiler.PTXCompilerTarget(; cap=llvm_cap, ptx=llvm_ptx, debuginfo), | ||
| ReactantPTXCompilerTarget{ReactantPTXBackend}(; cap=llvm_cap, ptx=llvm_ptx, debuginfo, backendinfo=ReactantPTXBackend(raising())), |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| ReactantPTXCompilerTarget{ReactantPTXBackend}(; cap=llvm_cap, ptx=llvm_ptx, debuginfo, backendinfo=ReactantPTXBackend(raising())), | |
| ReactantPTXCompilerTarget{ReactantPTXBackend}(; | |
| cap=llvm_cap, | |
| ptx=llvm_ptx, | |
| debuginfo, | |
| backendinfo=ReactantPTXBackend(raising()), | |
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…raising
companion to JuliaGPU/GPUCompiler.jl#823
cc @gbaraldi @vchuravy @giordano @maleadt
since GPUCompiler defines several APIs, like optimization_options, on the job itself -- downstream compilers that use the PTX codegen cannot modify these methods without type piracy on all targets, or vendoring the entire api.
Adding a type parameter to PTXCompilerTarget enables this to work without piracy or vendoring large parts of the codebase