Skip to content

Fix logger scope api usage#3304

Merged
wsmoses merged 1 commit into
mainfrom
lsapi
Jul 9, 2026
Merged

Fix logger scope api usage#3304
wsmoses merged 1 commit into
mainfrom
lsapi

Conversation

@wsmoses

@wsmoses wsmoses commented Jul 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/llvm/attributes.jl b/src/llvm/attributes.jl
index b5c823fe..6b2461ef 100644
--- a/src/llvm/attributes.jl
+++ b/src/llvm/attributes.jl
@@ -51,8 +51,8 @@ const nofreefns = Set{String}((
     "ijl_try_substrtod",
     "jl_try_substrtod",
     "jl_f__apply_iterate",
-    "jl_f_current_scope",
-    "ijl_f_current_scope",
+        "jl_f_current_scope",
+        "ijl_f_current_scope",
     "ijl_field_index",
     "jl_field_index",
     "julia.call",
@@ -265,8 +265,8 @@ const inactivefns = Set{String}((
     "jl_gc_get_total_bytes",
     "ijl_try_substrtod",
     "jl_try_substrtod",
-    "jl_f_current_scope",
-    "ijl_f_current_scope",
+        "jl_f_current_scope",
+        "ijl_f_current_scope",
     "ijl_tagged_gensym",
     "jl_tagged_gensym",
     "jl_get_world_counter",
@@ -603,8 +603,8 @@ function annotate!(mod::LLVM.Module)
         "ijl_get_nth_field_checked",
         "jl_f__svec_ref",
         "ijl_f__svec_ref",
-        "jl_f_current_scope",
-        "ijl_f_current_scope",
+            "jl_f_current_scope",
+            "ijl_f_current_scope",
         "UnsafeBufferPointer"
     )
         if haskey(funcs, fname)

@wsmoses wsmoses merged commit 1295371 into main Jul 9, 2026
57 of 88 checks passed
@wsmoses wsmoses deleted the lsapi branch July 9, 2026 17:10
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

main d9808c5... main / d9808c5...
basics/make_zero/namedtuple 0.0393 ± 0.0022 μs 0.0393 ± 0.0028 μs 1 ± 0.09
basics/make_zero/struct 0.206 ± 0.0062 μs 0.204 ± 0.0084 μs 1.01 ± 0.052
basics/overhead 3.08 ± 0.008 ns 2.81 ± 0.007 ns 1.1 ± 0.004
basics/remake_zero!/namedtuple 0.197 ± 0.0058 μs 0.196 ± 0.0068 μs 1 ± 0.046
basics/remake_zero!/struct 0.198 ± 0.007 μs 0.197 ± 0.0069 μs 1.01 ± 0.05
fold_broadcast/multidim_sum_bcast/1D 9.22 ± 1.1 μs 9.24 ± 1.1 μs 0.998 ± 0.17
fold_broadcast/multidim_sum_bcast/2D 9.21 ± 1.2 μs 9.22 ± 1.1 μs 0.998 ± 0.18
time_to_load 1.23 ± 0.014 s 1.26 ± 0.0062 s 0.98 ± 0.012

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/29035237423/artifacts/8206339344.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant