Skip to content

Don't use jl_lookup_code_address in windows#3287

Open
wsmoses wants to merge 1 commit into
mainfrom
nw
Open

Don't use jl_lookup_code_address in windows#3287
wsmoses wants to merge 1 commit into
mainfrom
nw

Conversation

@wsmoses

@wsmoses wsmoses commented Jul 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/compiler/validation.jl b/src/compiler/validation.jl
index a0d1b83c..de2cf26b 100644
--- a/src/compiler/validation.jl
+++ b/src/compiler/validation.jl
@@ -1326,7 +1326,7 @@ function check_ir!(interp, @nospecialize(job::CompilerJob), errors::Vector{IRErr
             else
                 ccall(:jl_lookup_code_address, Any, (Ptr{Cvoid}, Cint), ptr, 0)
             end
-            
+
             if length(frames) >= 1
                 fn, file, line, linfo, fromC, inlined = last(frames)
 

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

main 6f75f66... main / 6f75f66...
basics/make_zero/namedtuple 0.0552 ± 0.0022 μs 0.0549 ± 0.0024 μs 1 ± 0.059
basics/make_zero/struct 0.262 ± 0.0063 μs 0.262 ± 0.0065 μs 0.999 ± 0.035
basics/overhead 4.33 ± 0.01 ns 4.95 ± 0.01 ns 0.875 ± 0.0027
basics/remake_zero!/namedtuple 0.227 ± 0.011 μs 0.226 ± 0.0075 μs 1.01 ± 0.061
basics/remake_zero!/struct 0.224 ± 0.011 μs 0.222 ± 0.0076 μs 1.01 ± 0.062
fold_broadcast/multidim_sum_bcast/1D 10.2 ± 0.21 μs 10.3 ± 1.8 μs 0.992 ± 0.17
fold_broadcast/multidim_sum_bcast/2D 12 ± 0.27 μs 12.1 ± 0.26 μs 0.998 ± 0.031
time_to_load 1.53 ± 0.043 s 1.51 ± 0.052 s 1.02 ± 0.045

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/28824940028/artifacts/8122398228.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant