Skip to content

Fix false_from_args in tape type#3282

Merged
wsmoses merged 3 commits into
mainfrom
ttffa
Jul 6, 2026
Merged

Fix false_from_args in tape type#3282
wsmoses merged 3 commits into
mainfrom
ttffa

Conversation

@wsmoses

@wsmoses wsmoses commented Jul 5, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/Enzyme.jl b/src/Enzyme.jl
index 6932fcfc..dc42d250 100644
--- a/src/Enzyme.jl
+++ b/src/Enzyme.jl
@@ -164,7 +164,7 @@ import .Compiler: CompilationException
     ntuple(Returns(false), Val(N))
 end
 @inline function trues_from_args(N)
-    ntuple(Returns(true), Val(N))
+    return ntuple(Returns(true), Val(N))
 end
 
 @inline function any_active(args::Vararg{Annotation,N}) where {N}
@@ -1295,7 +1295,7 @@ import .Compiler: remove_innerty, UnknownTapeType
     end
 
     if ModifiedBetweenT === true
-        ModifiedBetween = trues_from_args(1+length(args))
+        ModifiedBetween = trues_from_args(1 + length(args))
     else
         ModifiedBetween = ModifiedBetweenT
     end

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

main ca0b9a7... main / ca0b9a7...
basics/make_zero/namedtuple 0.0548 ± 0.0025 μs 0.0563 ± 0.0025 μs 0.974 ± 0.063
basics/make_zero/struct 0.267 ± 0.0087 μs 0.262 ± 0.0071 μs 1.02 ± 0.043
basics/overhead 4.34 ± 0.01 ns 4.34 ± 0.01 ns 1 ± 0.0033
basics/remake_zero!/namedtuple 0.232 ± 0.0094 μs 0.228 ± 0.011 μs 1.02 ± 0.063
basics/remake_zero!/struct 0.228 ± 0.012 μs 0.224 ± 0.012 μs 1.02 ± 0.077
fold_broadcast/multidim_sum_bcast/1D 10.3 ± 0.45 μs 10.2 ± 0.22 μs 1.01 ± 0.049
fold_broadcast/multidim_sum_bcast/2D 12 ± 0.27 μs 12 ± 0.27 μs 1 ± 0.032
time_to_load 1.48 ± 0.0087 s 1.49 ± 0.0029 s 0.994 ± 0.0062

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/28799390453/artifacts/8112424658.

Comment thread src/Enzyme.jl Outdated
wsmoses and others added 2 commits July 6, 2026 06:52
Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
@wsmoses wsmoses merged commit 39b2721 into main Jul 6, 2026
75 of 89 checks passed
@wsmoses wsmoses deleted the ttffa branch July 6, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants