Conversation
Removed several tests for arithmetic operations using autodiff.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3233 +/- ##
===========================================
- Coverage 66.76% 23.97% -42.79%
===========================================
Files 65 53 -12
Lines 21522 20480 -1042
===========================================
- Hits 14369 4911 -9458
- Misses 7153 15569 +8416 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/runtests.jl b/test/runtests.jl
index 10920de6..46ef5c9c 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -14,5 +14,5 @@ Enzyme.Compiler.DumpPostOpt[] = true
bf64 = 0.56 # for testing mixed methods
dbf64 = 0.27 # for testing mixed methods
- @test autodiff(Enzyme.Forward, +, Duplicated, Duplicated(a, da), Duplicated(b, db))[:1] ≈ da+db
+ @test autodiff(Enzyme.Forward, +, Duplicated, Duplicated(a, da), Duplicated(b, db))[:1] ≈ da + db
end
diff --git a/test/test_isolated.jl b/test/test_isolated.jl
index 571c02b9..9c3cdb7f 100644
--- a/test/test_isolated.jl
+++ b/test/test_isolated.jl
@@ -11,35 +11,35 @@ function run_test()
A = T(M)
_A = T(A)
f!(Y, A, B, ::T) where {T} = ldiv!(Y, T(A), B)
-
+
dY = (zeros(TE, sizeB...), zeros(TE, sizeB...))
dM = (zeros(TE, n, n), zeros(TE, n, n))
-
+
activities = (
Const(f!),
BatchDuplicated(Y, dY),
BatchDuplicated(M, dM),
Const(B),
- Const(_A)
+ Const(_A),
)
-
+
forward, reverse = autodiff_thunk(
ReverseSplitWithPrimal,
Const{typeof(f!)},
BatchDuplicated, # return activity
map(typeof, Base.tail(activities))... # argument activities
)
-
+
println("Running targeted thunk forward...")
tape, y_ad, shadow_result = forward(Const(f!), Base.tail(activities)...)
-
+
ȳ = (ones(TE, sizeB...), ones(TE, sizeB...))
for (sr, dy) in zip(shadow_result, ȳ)
copyto!(sr, dy)
end
-
+
println("Running targeted thunk reverse...")
- reverse(Const(f!), Base.tail(activities)..., tape)
+ return reverse(Const(f!), Base.tail(activities)..., tape)
end
@testset "Isolated custom test" begin |
Contributor
Benchmark Results
Benchmark PlotsA plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/28308594457/artifacts/7930263780. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.