Skip to content

Pr3228#3233

Open
wsmoses wants to merge 8 commits into
mainfrom
pr3228
Open

Pr3228#3233
wsmoses wants to merge 8 commits into
mainfrom
pr3228

Conversation

@wsmoses

@wsmoses wsmoses commented Jun 25, 2026

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.97%. Comparing base (179b608) to head (202a436).
⚠️ Report is 179 commits behind head on main.

Files with missing lines Patch % Lines
src/utils.jl 75.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (179b608) and HEAD (202a436). Click for more details.

HEAD has 32 uploads less than BASE
Flag BASE (179b608) HEAD (202a436)
34 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3233       +/-   ##
===========================================
- Coverage   66.76%   23.97%   -42.79%     
===========================================
  Files          65       53       -12     
  Lines       21522    20480     -1042     
===========================================
- Hits        14369     4911     -9458     
- Misses       7153    15569     +8416     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/test/runtests.jl b/test/runtests.jl
index 10920de6..46ef5c9c 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -14,5 +14,5 @@ Enzyme.Compiler.DumpPostOpt[] = true
     bf64 = 0.56 # for testing mixed methods
     dbf64 = 0.27 # for testing mixed methods
 
-    @test autodiff(Enzyme.Forward, +, Duplicated, Duplicated(a, da), Duplicated(b, db))[:1] ≈ da+db 
+    @test autodiff(Enzyme.Forward, +, Duplicated, Duplicated(a, da), Duplicated(b, db))[:1] ≈ da + db
 end
diff --git a/test/test_isolated.jl b/test/test_isolated.jl
index 571c02b9..9c3cdb7f 100644
--- a/test/test_isolated.jl
+++ b/test/test_isolated.jl
@@ -11,35 +11,35 @@ function run_test()
     A = T(M)
     _A = T(A)
     f!(Y, A, B, ::T) where {T} = ldiv!(Y, T(A), B)
-    
+
     dY = (zeros(TE, sizeB...), zeros(TE, sizeB...))
     dM = (zeros(TE, n, n), zeros(TE, n, n))
-    
+
     activities = (
         Const(f!),
         BatchDuplicated(Y, dY),
         BatchDuplicated(M, dM),
         Const(B),
-        Const(_A)
+        Const(_A),
     )
-    
+
     forward, reverse = autodiff_thunk(
         ReverseSplitWithPrimal,
         Const{typeof(f!)},
         BatchDuplicated, # return activity
         map(typeof, Base.tail(activities))... # argument activities
     )
-    
+
     println("Running targeted thunk forward...")
     tape, y_ad, shadow_result = forward(Const(f!), Base.tail(activities)...)
-    
+
     ȳ = (ones(TE, sizeB...), ones(TE, sizeB...))
     for (sr, dy) in zip(shadow_result, ȳ)
         copyto!(sr, dy)
     end
-    
+
     println("Running targeted thunk reverse...")
-    reverse(Const(f!), Base.tail(activities)..., tape)
+    return reverse(Const(f!), Base.tail(activities)..., tape)
 end
 
 @testset "Isolated custom test" begin

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results

main 202a436... main / 202a436...
basics/make_zero/namedtuple 0.0587 ± 0.008 μs 0.0599 ± 0.0039 μs 0.979 ± 0.15
basics/make_zero/struct 0.249 ± 0.0085 μs 0.26 ± 0.0085 μs 0.959 ± 0.045
basics/overhead 4.88 ± 0.01 ns 4.54 ± 0.01 ns 1.08 ± 0.0032
basics/remake_zero!/namedtuple 0.232 ± 0.017 μs 0.232 ± 0.017 μs 1 ± 0.11
basics/remake_zero!/struct 0.232 ± 0.018 μs 0.232 ± 0.019 μs 1 ± 0.11
fold_broadcast/multidim_sum_bcast/1D 10.4 ± 0.38 μs 10.5 ± 0.62 μs 0.988 ± 0.069
fold_broadcast/multidim_sum_bcast/2D 12.8 ± 0.5 μs 12.7 ± 0.4 μs 1.01 ± 0.051
time_to_load 1.59 ± 0.014 s 1.61 ± 0.012 s 0.991 ± 0.012

Benchmark Plots

A plot of the benchmark results has been uploaded as an artifact at https://github.com/EnzymeAD/Enzyme.jl/actions/runs/28308594457/artifacts/7930263780.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant