Migrate test/passes.jl to FileCheck.jl#3224
Open
vchuravy wants to merge 4 commits into
Open
Conversation
Replace LLVM.jl IR introspection in the dead-arg removal pass tests with FileCheck directives over the printed post-pass module. The hand-written input IR is unchanged; only the assertion mechanism changes. Adds FileCheck to the test project. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The mismatched-calling-convention testset hard-coded typed-pointer syntax (i32* %arg1, i32* %arg2) in its @check, but under opaque pointers the callee prints as define internal fastcc void @callee(ptr nocapture writeonly %arg1, ...) Match the intent instead: the callee is preserved with both arguments. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The Partial return preservation testset hard-coded opaque-pointer syntax
(store atomic ptr addrspace(10) %v1), which fails on Julia 1.10/1.11
default configs that print typed pointers (store atomic {} addrspace(10)*
%v1). Match on the stored value instead so it works under both.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace LLVM.jl IR introspection in the dead-arg removal pass tests with
FileCheck directives over the printed post-pass module. The hand-written
input IR is unchanged; only the assertion mechanism changes.
Adds FileCheck to the test project.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com