Add reverse rule for Cholesky ldiv!#3108
Conversation
wsmoses
force-pushed
the
ldiv-chol-reverse
branch
from
fc25d8c to
81ff85b
Compare
| U = cache_fact.U | ||
| N = EnzymeRules.width(config) | ||
|
|
||
| for i in 1:N |
There was a problem hiding this comment.
you should make this an ntuple, not a regular for loop
Replace `for i in 1:N` with `ntuple(Val(N)) do i ... end` in the Cholesky ldiv! reverse rule, matching the forward rule pattern. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3108 +/- ##
==========================================
- Coverage 70.04% 69.99% -0.05%
==========================================
Files 66 66
Lines 21840 21879 +39
==========================================
+ Hits 15297 15314 +17
- Misses 6543 6565 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
actually taking a step back, what fails without this? |
|
specifically what is the error (we have potrf derivatives iirc) |
|
Yeah let me give you a more focused issue tomorrow or Tuesday. I was finding both failures in some cases and also some horrible performance. Can't remember which and when. Hold off on this until i can get the big picture to show you what is going on with errors, and/or massive performance differences |
2 participants
Summary
ldiv!(fact::Cholesky, B)test_reversecoverage for vector, matrix, const, and batched pathsTests
julia --project=test test/runtests.jl --verbose rules/internal_rules/linear_algebra_rules