Add forward rules for dense linear solves#3106
Conversation
|
@wsmoses This one I felt more confident implementing. Seems to pass tests/runic/etc. and I think it follows the patterns of others in that file. Let me know if you want anything changed. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3106 +/- ##
==========================================
- Coverage 70.04% 67.39% -2.65%
==========================================
Files 66 66
Lines 21840 21803 -37
==========================================
- Hits 15297 14694 -603
- Misses 6543 7109 +566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6c20f43 to
a13965e
Compare
|
same comment of fine for now, but we should tablegen likely here |
|
Yes on tablegen. I asked an AI to come up with tablegen but it ended up looking very complicated because of managing the pivots. But it got the dense LU stuff working and passing tests. Happy to post that up as a PR for you guys to look at and suggest changes/take it over. But not sure it is worth your time. |
Summary
A \ bandA \ Bcompute_lu_cachepath used by the reverse ruleA, and batched forward modeTests
julia --project=test test/runtests.jl --verbose rules/internal_rules/linear_algebra_rules