[WIP] Oceananigans integration tests

[glwagner]

This PR starts adding some integration tests. I noticed that the first thing I tried failed, so we'll have to work our way up.

Working on this with @giordano and @jtbuch

[github-actions]

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.

diff --git a/test/integration/Oceananigans/runtests.jl b/test/integration/Oceananigans/runtests.jl
index 45f388a4..92db3f64 100644
--- a/test/integration/Oceananigans/runtests.jl
+++ b/test/integration/Oceananigans/runtests.jl
@@ -3,14 +3,14 @@ using GPUArraysCore: @allowscalar
 using Oceananigans
 using Test
 
-function kinetic_energy(model, ν, K, dt=1)
+function kinetic_energy(model, ν, K, dt = 1)
     vitd = VerticallyImplicitTimeDiscretization()
     new_closure = ScalarDiffusivity(vitd; ν)
     tracer_names = keys(model.tracers)
     new_closure = Oceananigans.TurbulenceClosures.with_tracers(tracer_names, new_closure)
     model.closure = new_closure
 
-    for n = 1:10
+    for n in 1:10
         time_step!(model, dt)
     end
 
@@ -21,17 +21,19 @@ function kinetic_energy(model, ν, K, dt=1)
 end
 
 @testset "Column model with ScalarDiffusivity" begin
-    ν = 1e-3
-    grid = RectilinearGrid(size=128, z=(-64, 64), topology=(Flat, Flat, Bounded))
+    ν = 1.0e-3
+    grid = RectilinearGrid(size = 128, z = (-64, 64), topology = (Flat, Flat, Bounded))
     vitd = VerticallyImplicitTimeDiscretization()
     closure = ScalarDiffusivity(vitd; ν)
-    m = HydrostaticFreeSurfaceModel(; grid, closure, coriolis=FPlane(f=1e-4),
-        tracers=:b, buoyancy=BuoyancyTracer())
+    m = HydrostaticFreeSurfaceModel(;
+        grid, closure, coriolis = FPlane(f = 1.0e-4),
+        tracers = :b, buoyancy = BuoyancyTracer()
+    )
 
-    N² = 1e-6
+    N² = 1.0e-6
     bᵢ(z) = N² * z
     uᵢ(z) = exp(-z^2 / 10)
-    set!(m, b=bᵢ, u=uᵢ)
+    set!(m, b = bᵢ, u = uᵢ)
 
     u, v, w = m.velocities
     ke = (u^2 + v^2) / 2
@@ -40,11 +42,13 @@ end
     dm = Enzyme.make_zero(m)
     dK = Enzyme.make_zero(K)
 
-    dKdν = autodiff(set_strong_zero(Enzyme.ReverseWithPrimal),
-                    kinetic_energy, Active,
-                    Duplicated(m, dm),
-                    Active(ν),
-                    Duplicated(K, dK))
+    dKdν = autodiff(
+        set_strong_zero(Enzyme.ReverseWithPrimal),
+        kinetic_energy, Active,
+        Duplicated(m, dm),
+        Active(ν),
+        Duplicated(K, dK)
+    )
 
     @test dKdν[1][1] != 0
 end

[glwagner]

Looks like I need to be a little less ambitious probably

[wsmoses]

@giordano @glwagner so this is failing atm because allowscalar isn't currently supported in enzyme.jl natively [we should add cc @vchuravy ]

[jtbuch]

This might be relevant for you @dkytezab

[wsmoses]

1.10 just needs to be marked runtime activity.

1.11 hits a weird issue in an error handler, @vchuravy was looking at a while back but I don't think had cycles to look into for completion

[wsmoses]

@glwagner @giordano this code is now passing, anything else you wanted to add

[wsmoses]

I'm going to merge this for now @glwagner please update this with whatever else you care to have integration tested

[glwagner]

I think this is good to go -- we can keep working on it in future PRs