test GB CI for Oceananigans bump#2595
Open
Pangoraw wants to merge 6 commits into
Open
Conversation
Pangoraw
changed the title
Applies the fix from openxla/xla#45444 (spmd-enzyme: Be more conservative when walking constant DUS chain) on top of the pinned XLA commit. ProcessUpdatePieceExtractOperand's constant-DUS unwind loop was unconditionally descending into a nested DynamicUpdateSlice's update operand even when that update only partially covered the piece, discarding the real data in the DUS's base operand. This is the root cause traced for the sharded V=0 correctness bug (V = integral v dz coming out zero under Y-sharding of the NormalFlow barotropic velocity field's halo-fill pad). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2595 +/- ##
==========================================
+ Coverage 28.68% 31.07% +2.38%
==========================================
Files 225 225
Lines 44480 44512 +32
==========================================
+ Hits 12760 13833 +1073
+ Misses 31720 30679 -1041 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.