Add GB-25 PR #258 commit to test matrix for perf comparison#2563
Open
glwagner wants to merge 5 commits into
Open
Add GB-25 PR #258 commit to test matrix for perf comparison#2563glwagner wants to merge 5 commits into
glwagner wants to merge 5 commits into
Conversation
Member
|
cc @giordano |
Member
|
That's never the error, the error is always above: precompilation failed |
Member
|
https://github.com/EnzymeAD/Enzyme-JAX/actions/runs/27718231857/job/81996573379?pr=2563#step:16:803 |
Member
|
@glwagner so I think your GB update pr needs some work then |
Collaborator
Author
|
The precompile failure was from the pinned commit being stale: Bumped the pin to the current #258 head |
Member
|
Pin GB-25 commit 0590584 (from PRONTOLab/GB-25#258) alongside main so CI runs both and we can compare performance directly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The previous pin (0590584) predated commit ab53225 "Pin ClimaSeaIce for NumericalEarth CI", so ClimaSeaIce resolved to a version incompatible with Oceananigans v0.106 and failed to precompile. Use the current PR head a72b47b instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ipts) The previous pin a72b47b failed the GB-25 sharded compile with `MethodError: no method matching ka_with_reactant(...)` because that script did not load CUDA.jl (required for ReactantCUDAExt's KA-raising). bb161a7 adds `using CUDA`, so the test should run again. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
7dd8154 to
430e41e
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
… 0.2.268) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins GB-25 commit
0590584(from PRONTOLab/GB-25#258) alongsidemainin the GB-25 test matrix.This lets CI run both
mainand the PR #258 commit so we can compare performance side-by-side and confirm whether the perf gap is real or a model-config artifact.🤖 Generated with Claude Code