reverse diff of QRFactorizationOp#2543
Open
mofeing wants to merge 18 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2543 +/- ##
=======================================
Coverage 31.01% 31.02%
=======================================
Files 225 225
Lines 44446 44447 +1
=======================================
+ Hits 13787 13791 +4
+ Misses 30659 30656 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This reverts commit fec95b9.
(and also implement forward diff)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should be portable to TableGen, but it's easier to implement and debug in C++ first.
literature only has rules for the generic QR op and for the CompactWY (
geqrt) but this is a lil bit trickier. forgeqrf, the QR packed format, there doesn't seem to be a known direct mapping.requires #2544 for the
GemmOpsupport