Configure git identity before rebase in auto-commit workflows#1474
Merged
Conversation
The auto-commit workflows set commit_user_name/commit_user_email on the git-auto-commit-action, but those inputs only apply to the commit the action itself creates -- they are not persisted to the repository's git config. With skip_push: true, the custom "Push changes with retry" step runs `git pull --rebase origin main` when the first push is rejected as non-fast-forward. The rebase replays the local commit and needs a committer identity from git config, which was never set, so it fails with "empty ident name ... not allowed" (exit 128). Add a "Configure git identity for rebase" step that runs `git config` before the retry push, matching the working pattern already used in the data-generation repos. This makes the rebase-on-retry path resilient to concurrent pushes to main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for nifty-bardeen-5c7e53 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The auto-commit workflows failed with
fatal: empty ident name ... not allowed(exit 128) — see run 26842996203:Root cause
These workflows use
stefanzweifel/git-auto-commit-actionwithskip_push: true, then push via a custom "Push changes with retry" step that runsgit pull --rebase origin mainwhen the first push is rejected as non-fast-forward.The action's
commit_user_name/commit_user_emailinputs apply only to the commit the action creates — they are not persisted to the repository'sgit config. When the retry step rebases, git replays the local commit and needs a committer identity fromgit config, which was never set →empty ident name.Fix
Add a
Configure git identity for rebasestep that runsgit configbefore the retry push, gated by the samechanges_detectedcondition. This mirrors the working pattern already used in the data-generation repos (andpodcast-metadata'sstate-manager.yml).Applied to all 6 auto-commit workflows in this repo:
prettier.ymlcheck-tags-without-descriptions.ymlupdate-podcast-episodes-from-rss.ymlsync-german-tech-podcasts.ymlsync-awesome-software-engineering-movies.ymlsync-awesome-software-engineering-games.ymlVerification
id: auto-commitstep andPush changes with retry, matching each file's existingworking-directorystyle.empty ident nameerror.🤖 Generated with Claude Code