Let each meetup region override the talk-start offset#1456
Merged
andygrunwald merged 1 commit intoMay 20, 2026
Conversation
MeetupPageLayout hard-coded 'talks start ~30min later' in the date-and-time line, which was correct for the Alps meetup but wrong for Rhine-Ruhr, where the open-doors-to-first-talk gap is about an hour. Add an optional talkStartOffset prop with a default of '~30min', so the Alps page (which doesn't pass the prop) is unchanged. Rhine-Ruhr now passes '~1h', producing 'talks start ~1h later'. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for nifty-bardeen-5c7e53 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MeetupPageLayout.astrohard-codedtalks start ~30min laterinto the date-and-time line shown above the registration form. That value is accurate for the Alps meetup, but at the Rhine-Ruhr meetup the gap between doors opening and the first talk is roughly an hour, so the line was misleading there.What changed
src/components/meetup/MeetupPageLayout.astro— added an optionaltalkStartOffsetprop with a default of'~30min'and threaded it into the date-and-time template literal. The Alps page does not pass the prop, so its rendered copy is byte-for-byte unchanged.src/pages/meetup/rhine-ruhr/index.astro— passestalkStartOffset="~1h".2 files changed, +4 / −1.
Rendered output (verified against
dist/)/meetup/alps/→… open doors at HH:MM (talks start ~30min later)✓/meetup/rhine-ruhr/→… open doors at HH:MM (talks start ~1h later)✓Validation
make build→ ✓ 477 pages built in 5.73smake test-javascript→ ✓ 86/86website-admin/files touched; Go commands not applicable.🤖 Generated with Claude Code