Upgrade vendored Podigee podcast player to 9931784#1445
Open
andygrunwald wants to merge 4 commits into
Open
Conversation
The webpage uses the Podigee player in iframe-script mode: the loader JS creates an iframe to `podigee-podcast-player.html`, and the fork's build pipeline inlines the theme CSS and the embed JS bundle into that HTML file. As a result, the following vendored files exist on disk but are never requested by the browser at runtime: - `public/podcast-player/stylesheets/app.css` (inlined into the HTML) - `public/podcast-player/themes/default/index.css` (inlined) - `public/podcast-player/themes/default/index.html` (build-time template, not served) - `public/podcast-player/fonts/podigee-podcast-player.json` (icomoon metadata; not referenced by any @font-face, ~1.88 MB) Removing them shrinks the vendored snapshot by ~1.9 MB and keeps future re-syncs from `build/` focused on files we actually serve. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Refresh the vendored Podigee Podcast Player snapshot from the fork's
build/ directory. The previous pin was `5134f68` (Dec 2024); this bumps
to `9931784` on branch `andygrunwald/migrate-yarn-1-to-yarn-4`.
The fork has accumulated the following changes since the last sync,
none of which alter the integration contract used in
`src/layouts/podcast-episode.astro` (the `<script class="podigee-podcast-player">`
loader and the `window.playerConfiguration` shape are unchanged):
- Sass modernization: migrated `@import` to `@use`, replaced deprecated
`lighten()` with `color.adjust()`.
- Dependency lockfile maintenance and pinning, jQuery 4.x bump, Sass
1.x updates, Node 24, dropping `node-sass`.
- Build-tooling migration from Yarn 1 to Yarn 4.
Files updated:
- `public/podcast-player/podigee-podcast-player.html` — iframe document
(now ships the build's minified inlined CSS; the on-disk size drops
from ~610 KB to ~360 KB even though functional content is equivalent)
- `public/podcast-player/javascripts/podigee-podcast-player.js` — loader
- `public/podcast-player/fonts/podigee-podcast-player.{ttf,woff,eot}` —
icon font (svg is byte-identical to the previous snapshot)
- `public/podcast-player/images/chromcast.png` — UI icon
- `public/podcast-player/README.md` — pointer bumped to the new commit
and branch; cross-link to the upgrade doc added
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add `docs/upgrade-podigee-podcast-player.md` as the canonical reference for refreshing the vendored Podigee fork under `public/podcast-player/`. The previous upgrade required reverse-engineering which build artifacts the iframe actually loads versus which ones are inlined into `podigee-podcast-player.html` at build time; the new doc captures that mapping so future sync passes are mechanical. Coverage: - How the player is integrated (iframe-script mode and where the loader sits in `src/layouts/podcast-episode.astro`). - Authoritative list of files we vendor (HTML, loader, fonts, icon). - Files in the fork's `build/` we intentionally skip and why (direct-mode bundles, `.gz` siblings, other themes, the icomoon metadata JSON, the standalone CSS that the build already inlines). - A step-by-step upgrade procedure ending in a manual smoke test that catches regressions in `public/js/podcast-player-tracking.js` — the bridge most affected by any change to the iframe's `playerjs` event shape. Cross-link the new doc from the top-level `README.md` and `AGENTS.md` "Podcast player" sections. The Embedly `player.js` upgrade path stays in the README since it has nothing to do with the Podigee fork. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Run `prettier --write` on the newly added `docs/upgrade-podigee-podcast-player.md` so the file ships in the project's enforced style (table column padding, single-line HTML attribute layout in code samples, no double spaces in list items). This is the only file from this branch that prettier flagged; the other 89 pre-existing offenders elsewhere in the repo are left for the monthly `Code formatting` workflow to handle. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for nifty-bardeen-5c7e53 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
public/podcast-player/from5134f68(Dec 2024) to9931784on the fork'sandygrunwald/migrate-yarn-1-to-yarn-4branch.stylesheets/app.css,themes/default/*, andfonts/*.jsonare dead weight).docs/upgrade-podigee-podcast-player.mdso the next upgrade is mechanical: it captures which files we vendor, whichbuild/outputs we intentionally skip and why, and the step-by-step procedure.Commits
chore(podcast-player): drop unused vendored build artifacts— remove dead weight.chore(podcast-player): update vendored player to 9931784— refresh the runtime files (podigee-podcast-player.html, loader JS, fonts,chromcast.png) and bump thepublic/podcast-player/README.mdpointer.docs: document Podigee podcast player upgrade procedure— add the upgrade guide and cross-link it fromREADME.mdandAGENTS.md.style(docs): apply prettier formatting to upgrade doc— match project formatting on the new doc.Fork commit included in this bump:
9931784…(Sass@import → @usemigration, jQuery 4.x, Sass 1.x, Node 24, droppingnode-sass, Yarn 1 → Yarn 4 build-tooling migration).Notes for review
podigee-podcast-player.htmlis huge (~15k line deletions) because the new build minifies the inlined CSS; functional content is equivalent. Focus on the smoke test rather than line-by-line review..prettierignore, so the prettier monthly job won't touch them.andygrunwald/migrate-yarn-1-to-yarn-4). A follow-up can re-pin to a merged commit once the fork's branch lands.Test plan
make build— Astro build succeeds, all 7 expected files emitted underdist/podcast-player/, no orphan references to the removed files.make test-javascript— 60/60 tests pass.prettier --checkon the files touched by this branch — clean (pre-existing repo-wide warnings unchanged).make run: iframe renders, play/pause/chapter marks work, transcript click jumps audio, DevTools shows only expected/podcast-player/...requests, Matomo_paq.pushentries fire on play/pause/ended.🤖 Generated with Claude Code