TuHo_Week2-DB-Redis#18
Open
hoanhtu wants to merge 1 commit into
Open
Conversation
tpdongcs
reviewed
Jun 5, 2023
| } | ||
|
|
||
| // Tạo session id ngẫu nhiên | ||
| rand.Seed(time.Now().UnixNano()) |
Collaborator
There was a problem hiding this comment.
random like this can make collision rate high if number of user is big , you should use uuid, or hash from user_name
|
|
||
| value, err := redisClient.Get(redisClient.Context(), sessionID).Result() | ||
| if err != nil { | ||
| c.AbortWithStatusJSON(429, gin.H{"error": "cant get data user"}) |
|
|
||
| if errPing != nil || now-timeCount > 60 { | ||
| myMap := map[string]interface{}{ | ||
| "timeCount": now, |
Collaborator
There was a problem hiding this comment.
no need to implement like this, only need to store the count number (no need time) then set an expire time for it (60s in this case) then if it over 60s, this key will be deleted (which mean if someone increase or get will be 0)
| } | ||
|
|
||
| // Truy vấn số lượng request của người dùng đó từ Redis | ||
| count, err := redisClient.Get(redisClient.Context(), keyUser).Int() |
Collaborator
There was a problem hiding this comment.
can get the count number from the response of incr command instead, no need to call one more time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.