fix: consolidated SI price list + SI->DN connection button#27
Merged
Conversation
…N button Two issues on the net-off consolidation path (_build_consolidated_standard_si): (1) the SI never set selling_price_list, so it fell back to the customer/default list (e.g. Retail Price) instead of the DN's (e.g. Inter Company Price) — now carried over; item rates stay set explicitly from netted amounts so amounts don't change. (2) Connections tab can't show the source DNs (net-off merges rows → no per-row delivery_note/si_detail mapping; setting them trips validate_multiple_billing) — added a 'Delivery Notes' button (View group) on Sales Invoice linking to DNs filtered by custom_consolidated_si. DN->SI direction already works via the DN field. Regression test for price-list carryover added. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Net-off consolidation (
_build_consolidated_standard_si): (1) carry the DNselling_price_list(e.g. Inter Company Price) onto the SI — was defaulting to Retail Price; rates still set explicitly so amounts are unchanged. (2) add a 'Delivery Notes' View-button on the SI linking to source DNs viacustom_consolidated_si(Connections tab can't be populated without breaking the net-off). Regression test added.