Fix problems with TwoLevelTree#94
Merged
Merged
Conversation
hellemo
approved these changes
Jun 15, 2026
hellemo
left a comment
hellemo
left a comment
Member
There was a problem hiding this comment.
The explanation is perhaps a bit terse, but looks good to me in general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when using
TwoLevelTreetime structures. In this case, all variables indexed over strategic variables included the multiplication with the branch probability. As a consequence, emission limits were less meaningful. In addition, using the functionscale_op_spfor equality constraints could lead to infeasible problems.This is adjusted in this version.
The PR includes furthermore some minor additional adjustments.