✨ Add ErrorPage layout component#20
Merged
Merged
Conversation
Closes #18. Replaces the abandoned @EnabelLayout/error/base.html.twig from enabel/layout-bundle. Renders a self-contained <!DOCTYPE html> page (no base.html.twig extension) and emits the markup expected by @enabel/enabel-bootstrap-theme/dist/css/error.min.css. Introduces the Layout/ component namespace.
Member
Author
|
Smoke-tested in Impala (consumer app) — symlinked the branch via composer path repo, no patches needed. What I verified
One suggestion for the docs
LGTM otherwise, ready to tag. |
Member
Author
|
Doc updated in 68a038e — 5xx convention added as a tip block right after the generic error template example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ErrorPagecomponent that replaces the abandoned@EnabelLayout/error/base.html.twigfromenabel/layout-bundleLayout/component namespace (paves the way for Add an EmailLayout component (replace abandoned enabel/layout-bundle email base) #17 EmailLayout and Add a LoginCard layout component (centered card on a solid background) #19 LoginCard)<!DOCTYPE html>page (does not extendbase.html.twig— error pages must keep working when the asset pipeline is broken)@enabel/enabel-bootstrap-theme/dist/css/error.min.cssAPI
Required: `statusCode`, `title`, `message`. Optional: `details`, `backUrl`, `backLabel`, `symbol`, `logo`, `locale`, `appName`, `stylesheet`.
Test plan
Closes #18.