Bug Fix: Fixes issues with API that finds viewers #292
Open
MrNanosh wants to merge 13 commits into
Open
Conversation
…hanged the button text to say important electionn information above the header
…into hartfordPart4#196
…ord-address-lookup: a deepcopy of viewers was necessary to see nested arrays in viewer object and there was code duplication in the https get function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The branch was started to create an interface where organizations like Harford's Voters coalition could insert an iframe with viewers relevant to local elections. The interface was put in the Backlog but this branch contains fixes to the original API that allows the retrieval of viewers by address.
The bug: submitting the address would find viewers but the function responsible for searching the database was not returning them despite the object returning non-empty. The problem was that a shallow copy was being made where a deep copy was needed to get the data containing URLs to viewers.