perf: use in-place cleanup for dedup and rate-limit caches (issue #192)#196
Merged
Conversation
- _is_duplicate: replace dict comprehension rebuild with in-place deletion of expired keys - _is_rate_limited: add same in-place cleanup for _last_alert_time (was unbounded) - Both caches now delete only expired entries instead of reconstructing the entire dict on every call Closes #192
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #192. Replaces dict comprehension rebuilds with in-place cleanup of expired entries in both the dedup cache and rate-limit cache.
Changes
_is_duplicate: Instead ofself._dedup_cache = {k: v for k, v in ...}(rebuilds entire dict every call), now collects expired keys into a list and deletes them in-place. Under high alert throughput this avoids O(n) dict reconstruction on every event._is_rate_limited: Added same in-place cleanup for_last_alert_time, which previously grew unbounded — every unique device key was kept forever even after the rate limit window expired.Test Results