Skip to content

Fix namespaced mode#6

Merged
gcaracuel merged 3 commits into
mainfrom
fix/namespaced_mode
Sep 11, 2025
Merged

Fix namespaced mode#6
gcaracuel merged 3 commits into
mainfrom
fix/namespaced_mode

Conversation

@gcaracuel

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings September 11, 2025 13:25
@gcaracuel gcaracuel self-assigned this Sep 11, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the namespaced mode by configuring the operator to work properly with namespace-scoped RBAC permissions instead of cluster-wide permissions. This enhances security by limiting the operator's access scope to only the target namespace.

  • Updates default RBAC configuration to use namespace-scoped permissions
  • Adds automatic namespace-scoped caching when not using cluster roles
  • Removes hardcoded namespace references from examples to make them more flexible

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
deploy/helm/dapr-trustbundle/values.yaml Changes default RBAC to use namespace-scoped permissions
deploy/helm/dapr-trustbundle/templates/deployment.yaml Adds USE_NAMESPACE_CACHE environment variable for namespace-scoped deployments
cmd/main.go Implements namespace-scoped caching based on environment variable
examples/test-secret.yaml Removes hardcoded namespace to allow flexible deployment
examples/certificate.yaml Removes hardcoded namespace to allow flexible deployment
config/default/kustomization.yaml Updates default namespace from dapr-trustbundle-system to dapr-system
config/manager/kustomization.yaml Updates image configuration for deployment
README.md Comprehensive documentation updates explaining the new namespaced mode

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread cmd/main.go
Comment thread cmd/main.go
@gcaracuel gcaracuel merged commit ad4eadd into main Sep 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants