Fix namespaced mode#6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the namespaced mode by configuring the operator to work properly with namespace-scoped RBAC permissions instead of cluster-wide permissions. This enhances security by limiting the operator's access scope to only the target namespace.
- Updates default RBAC configuration to use namespace-scoped permissions
- Adds automatic namespace-scoped caching when not using cluster roles
- Removes hardcoded namespace references from examples to make them more flexible
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| deploy/helm/dapr-trustbundle/values.yaml | Changes default RBAC to use namespace-scoped permissions |
| deploy/helm/dapr-trustbundle/templates/deployment.yaml | Adds USE_NAMESPACE_CACHE environment variable for namespace-scoped deployments |
| cmd/main.go | Implements namespace-scoped caching based on environment variable |
| examples/test-secret.yaml | Removes hardcoded namespace to allow flexible deployment |
| examples/certificate.yaml | Removes hardcoded namespace to allow flexible deployment |
| config/default/kustomization.yaml | Updates default namespace from dapr-trustbundle-system to dapr-system |
| config/manager/kustomization.yaml | Updates image configuration for deployment |
| README.md | Comprehensive documentation updates explaining the new namespaced mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.