Skip to content

Fix validation not being recalculated in inbound fee policy fields #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markettes merged 2 commits into from
Jul 7, 2026
Merged

Fix validation not being recalculated in inbound fee policy fields #532

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d6b5eb
fix: refactor validation layout for inbound fee policy fields in Chan…
markettes Jul 6, 2026
2d3a0fa
Merge branch 'main' into fix/validation-channel-fees
markettes Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions src/Pages/Channels.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@
{
<Alert Color="Color.Info" Visible="true" class="mb-4">
<AlertDescription>
<Spinner Size="SpinnerSize.Small"></Spinner> Loading current fee policies...

Check warning on line 531 in src/Pages/Channels.razor

View workflow job for this annotation

GitHub Actions / unit-test 

Found markup element with unexpected name 'Spinner'. If this is intended to be a component, add a @using directive for its namespace.
</AlertDescription>
</Alert>
}
Expand Down Expand Up @@ -678,9 +678,9 @@
policy unchanged.</FieldHelp>
</Field>
<Row>
<Column>
<Field>
<Validation Validator="ValidateInboundFeePolicy">
<Validation Validator="ValidateInboundFeePolicy">
<Column>
<Field>
<FieldLabel>Inbound base fee (msat)</FieldLabel>
<FieldHelp>Optional inbound base fee. When set, it must be zero or below.
Comment thread
markettes marked this conversation as resolved.
</FieldHelp>
Expand All @@ -690,12 +690,10 @@
<ValidationError />
</Feedback>
</NumericEdit>
</Validation>
</Field>
</Column>
<Column>
<Field>
<Validation Validator="ValidateInboundFeePolicy">
</Field>
</Column>
<Column>
<Field>
<FieldLabel>Inbound fee rate (ppm)</FieldLabel>
<FieldHelp>Optional inbound proportional fee. When set, it must be zero
or below.</FieldHelp>
Expand All @@ -705,9 +703,9 @@
<ValidationError />
</Feedback>
</NumericEdit>
</Validation>
</Field>
</Column>
</Field>
</Column>
</Validation>
</Row>
</Validations>
</TabPanel>
Expand Down
Loading