Handle same-peer loop in rebalance process#518
Closed
markettes wants to merge 0 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the rebalance execution flow to detect a “same-peer loop” scenario during route probing (where a probed route loops back to the source node) and treat it as a NoRoute outcome, plus adds unit coverage to ensure payments are not dispatched in that case.
Changes:
- Add rebalance probe validation that flips the attempt to
NoRoutewhen the probed route’s last hop is the source node. - Add a unit test to verify the loop case schedules a retry and does not call
SendPaymentV2Async. - Update existing tests’ probe stubs to return non-empty routes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Services/RebalanceService.cs | Adds same-peer loop detection during probe success handling and maps it to the existing NoRoute retry path. |
| test/NodeGuard.Tests/Services/RebalanceServiceTests.cs | Adds coverage for the new loop detection behavior and adjusts existing probe-success stubs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+261
to
+265
| if (success.Route.Hops[^1].PubKey == rebalance.SourceNodePubKey) | ||
| { | ||
| _logger.LogInformation( | ||
| "Rebalance {RebalanceId} probe route's last hop is the source node itself; treating as NoRoute", | ||
| rebalance.Id); |
markettes
force-pushed
the
fix/block-rebalance-same-peer
branch
from
60138d0 to
9f38d37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement logic to detect when a probed route's last hop is the source node, treating it as a NoRoute scenario. Add unit tests to ensure proper handling of this case.