Skip to content

Fix withdrawal amount handling on frontend#415

Merged
Jossec101 merged 1 commit into
mainfrom
fix-withdrawals-amount-ui-bug
Jun 19, 2025
Merged

Fix withdrawal amount handling on frontend#415
Jossec101 merged 1 commit into
mainfrom
fix-withdrawals-amount-ui-bug

Conversation

@Jossec101

Copy link
Copy Markdown
Contributor

Ensure the withdrawal amount is set correctly when saving

@Jossec101 Jossec101 requested review from RodriFS and Copilot June 19, 2025 10:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that withdrawal destinations and their amounts are correctly initialized on the frontend and that each destination record has proper timestamps in the repository layer.

  • Frontend: Initialize WalletWithdrawalRequestDestinations with the correct amount when saving and handle edits to the destination address.
  • Frontend: Reset destination list on address change (currently to zero, but this may need adjustment).
  • Backend: Set creation and update datetimes for each withdrawal destination.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/Pages/Withdrawals.razor Adds and updates initialization of WalletWithdrawalRequestDestinations on save and address edit.
src/Data/Repositories/WalletWithdrawalRequestRepository.cs Initializes creation/update datetimes for each destination.
Comments suppressed due to low confidence (2)

src/Data/Repositories/WalletWithdrawalRequestRepository.cs:138

  • [nitpick] The comment refers to "types" but the code is setting creation/update timestamps. Consider updating it to "// Set creation and update datetimes for each destination".
            // Set the types for the destinations

src/Pages/Withdrawals.razor:593

  • The variable amount is not defined in this context, which will cause a compilation error. Consider using _amount or the calculated value from _selectedUTXOs.
                Amount = amount

Comment thread src/Pages/Withdrawals.razor
@Jossec101 Jossec101 merged commit 7cd69e8 into main Jun 19, 2025
5 checks passed
@Jossec101 Jossec101 deleted the fix-withdrawals-amount-ui-bug branch June 19, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants