Fix withdrawal amount handling on frontend#415
Merged
Conversation
…en saving on the repo
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that withdrawal destinations and their amounts are correctly initialized on the frontend and that each destination record has proper timestamps in the repository layer.
- Frontend: Initialize
WalletWithdrawalRequestDestinationswith the correct amount when saving and handle edits to the destination address. - Frontend: Reset destination list on address change (currently to zero, but this may need adjustment).
- Backend: Set creation and update datetimes for each withdrawal destination.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Pages/Withdrawals.razor | Adds and updates initialization of WalletWithdrawalRequestDestinations on save and address edit. |
| src/Data/Repositories/WalletWithdrawalRequestRepository.cs | Initializes creation/update datetimes for each destination. |
Comments suppressed due to low confidence (2)
src/Data/Repositories/WalletWithdrawalRequestRepository.cs:138
- [nitpick] The comment refers to "types" but the code is setting creation/update timestamps. Consider updating it to "// Set creation and update datetimes for each destination".
// Set the types for the destinations
src/Pages/Withdrawals.razor:593
- The variable
amountis not defined in this context, which will cause a compilation error. Consider using_amountor the calculated value from_selectedUTXOs.
Amount = amount
RodriFS
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the withdrawal amount is set correctly when saving