Skip to content

flake: fix in-flight statuses causing flakyness when asserting payment success/failure #9238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ScuttoZ wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

flake: fix in-flight statuses causing flakyness when asserting payment success/failure #9238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/test_pay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5312,6 +5312,17 @@ def test_sendpay_grouping(node_factory, bitcoind):
# And finally we should have all 3 attempts to pay the invoice
pays = l1.rpc.listpays()['pays']
assert(len(pays) == 3)

# xpay returns the failure to the caller before it finishes cleaning up
# the payment, so a failed attempt can still be reported as 'pending'
# (attempt_ongoing() -> true) right after the rpc returns. Each xpay payment
# owns a private "xpay-<n>" askrene layer which is removed in that same cleanup,
# so wait for them all to disappear before checking the exact statuses.
# If payment hangs indefinetly, the default timeout will fail the test
# (60s/180s if SLOW_MACHINE=1).
wait_for(lambda: not any(layer['layer'].startswith('xpay-')

@Andezion Andezion Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait_for waits for any xpay-* layers to disappear from the node, not just those related to these three payments. If there were other xpay calls on the same L1 earlier in the test, you might accidentally end up waiting for someone else's cleanup. Make sure there were no pending third-party xpay payments on l1 prior to this point

for layer in l1.rpc.askrene_listlayers()['layers']))
pays = l1.rpc.listpays()['pays']
assert([p['status'] for p in pays] == ['failed', 'failed', 'complete'])


Expand Down
Loading