tests: test unilateral closing with unknown fees + cpfp with withdraw#8879
Open
enaples wants to merge 3 commits into
Open
tests: test unilateral closing with unknown fees + cpfp with withdraw#8879enaples wants to merge 3 commits into
withdraw#8879enaples wants to merge 3 commits into
Conversation
ad509ff to
9e68027
Compare
Member
|
Rebased on top of |
Member
|
The linter is not happy about the coding standards, @enaples please address the warnings and push again. |
cdecker
reviewed
Jul 9, 2026
| close_feerate = close_fees * 10**8 / (close_vsize * 4 / 1000) | ||
|
|
||
| # Create 1 block but exclude the closing tx (feerate too low). | ||
| bitcoind.generate_block(1, needfeerate=close_feerate + 1) |
Member
There was a problem hiding this comment.
Cool trick, didn't know this one yet 👍
c0dc1e6 to
9e68027
Compare
f6da09e to
881d537
Compare
Collaborator
|
Not sure how i'm getting added as a reviewer because of code ownership here but ok. The test is not passing and the commits need to be squashed into one please. And the error is correct i think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
26.04 FREEZE March 11th: Non-bugfix PRs not ready by this date will wait for 26.06.
RC1 is scheduled on March 23rd
The final release is scheduled for April 15th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgradeAdditional Info
The test is meant to test the ability to perform a Child Pays For Parent on an unilateral channel close with custom feerate.
Steps
Changelog-None